linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	linux-rdma@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	linux-um@lists.infradead.org
Subject: Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML
Date: Thu, 1 Dec 2022 12:12:23 +0200	[thread overview]
Message-ID: <Y4h+B7vEvkgbMbZ7@unreal> (raw)
In-Reply-To: <9fdd6581efb75511f3259ca663cd1afaee4ae4ac.camel@sipsolutions.net>

On Thu, Dec 01, 2022 at 10:28:18AM +0100, Johannes Berg wrote:
> On Thu, 2022-12-01 at 11:22 +0200, Leon Romanovsky wrote:
> > 
> > > +++ b/drivers/infiniband/hw/qib/Kconfig
> > > @@ -3,6 +3,7 @@ config INFINIBAND_QIB
> > >  	tristate "Intel PCIe HCA support"
> > >  	depends on 64BIT && INFINIBAND_RDMAVT
> > >  	depends on PCI
> > > +	depends on !UML
> > 
> > I would advocate to add this line to whole drivers/infiniband.
> > None of RDMA code makes sense for UML.
> > 
> 
> You could argue that one might want to eventually use kunit for some
> bits and pieces in there, so it'd make sense to be able to build the
> parts that _can_ be built, but I have no idea :)

But now, we don't have anyone in RDMA who uses kunit. Once it will be
needed, he/she will extend drivers/infiniband to support it.

Thanks

> 
> johannes

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

  reply	other threads:[~2022-12-01 10:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 20:09 [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML Randy Dunlap
2022-12-01  9:22 ` Leon Romanovsky
2022-12-01  9:28   ` Richard Weinberger
2022-12-01  9:28   ` Johannes Berg
2022-12-01 10:12     ` Leon Romanovsky [this message]
2022-12-01 17:15   ` Christoph Hellwig
2022-12-01 18:05     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4h+B7vEvkgbMbZ7@unreal \
    --to=leon@kernel.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=jdike@addtoit.com \
    --cc=jgg@nvidia.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).