From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 16 Feb 2022 07:28:28 -0800 From: Christoph Hellwig Subject: Re: [PATCH v2] parport_pc: Also enable driver for PCI systems Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Maciej W. Rozycki" Cc: Christoph Hellwig , Sudip Mukherjee , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 09:11:45AM +0000, Maciej W. Rozycki wrote: > On Mon, 14 Feb 2022, Christoph Hellwig wrote: > > > > =================================================================== > > > --- linux-macro.orig/arch/arm64/include/asm/Kbuild > > > +++ linux-macro/arch/arm64/include/asm/Kbuild > > > @@ -3,6 +3,7 @@ generic-y += early_ioremap.h > > > generic-y += mcs_spinlock.h > > > generic-y += qrwlock.h > > > generic-y += qspinlock.h > > > +generic-y += parport.h > > > > Instead of adding generic-y just ad a mandatory-y in > > include/asm-generic/Kbuild. > > I'm inconvinced. Not all archs want it, 5 don't. Which is exactly what mandatory-y is for. Provide the asm-generic version by default, but let architectures override it. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um