Re: [PATCH] Kconfig: eradicate CC_HAS_ASM_GOTO

Borislav Petkov
2022-08-19T17:12:23Z

On Fri, Aug 19, 2022 at 10:00:53AM -0700, Nick Desaulniers wrote:
> GCC has supported asm goto since 4.5, and Clang has since version 9.0.0.
> The minimum supported versions of these tools for the build according to
> Documentation/process/changes.rst are 5.1 and 11.0.0 respectively.
>
> Remove the feature detection script, Kconfig option, and clean up some
> fallback code that is no longer supported.
>
> The removed script was also testing for a GCC specific bug that was
> fixed in the 4.7 release.
>
> The script was also not portable; users of Dash shell reported errors
> when it was invoked.
>
> Link: https://lore.kernel.org/lkml/CAK7LNATSr=BXKfkdW8f-H5VT_w=xBpT2ZQcZ7rm6JfkdE+QnmA@mail.gmail.com/
> Link: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48637
> Reported-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> Documentation/kbuild/kconfig-language.rst | 4 ++--
> arch/Kconfig | 3 +--
> arch/um/include/asm/cpufeature.h | 4 ++--
> arch/x86/Makefile | 4 ----
> arch/x86/include/asm/cpufeature.h | 4 ++--
> arch/x86/include/asm/rmwcc.h | 19 +------------------
> arch/x86/kvm/emulate.c | 2 +-
> init/Kconfig | 4 ----
> scripts/gcc-goto.sh | 22 ----------------------
> tools/arch/x86/include/asm/rmwcc.h | 21 ---------------------
> 10 files changed, 9 insertions(+), 78 deletions(-)
> delete mode 100755 scripts/gcc-goto.sh

Nice and good riddance.

Acked-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.