From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 796A0E7718E for ; Mon, 23 Dec 2024 07:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tpXH6fpTjEphVQKpFxQ2V5QkwIF19GVaeym7wiAED5s=; b=GEkt6i7E8toMHbP8OKXisUotN3 sDK4aF1jQGDjgF8kGTnK5gFGuRvVlzsL5HZEkcZS4kg02fnVpHdFv4gd0Fq4FHnKY+lvSN646Nu1k NsswWae/sIa77f8hr2/bF58RCCEj4MXSOghGENg8qo55wCghUm2UYjwQ448vle5q5x2iuErNGz1ip TjcrGdbbJSPoAiWJLX8/OivJB33RtlX6qpaQjnWG5BDr1rtyVLlqycSxcf18tTN/ZZST8OykrBY1a ArO5Pfd1PHBnG0YnMMUs6kPW3AyO+NNC7tbhsynsw3X7JxL9zLR4HVEsOdI1yG4COi5yn37xJuONI QWLf5pJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tPccY-00000009Uxg-3vmw; Mon, 23 Dec 2024 07:12:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tPccU-00000009UwB-3Y9n; Mon, 23 Dec 2024 07:12:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C64ED5C4A8D; Mon, 23 Dec 2024 07:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2221C4CED4; Mon, 23 Dec 2024 07:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734937968; bh=KiW6z79yHKtUcMEX/b8/Sp0F2L3XtvvNObnoy9wnwCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PadoaIur+Bq/ska4dZ3htQaJQz4uazLSVowJVHucSNC53reVkWxd5YVJWY/8jYQei G/2ikWxztSp4IduffOwXB0a3mVJH23t9Ex7EGVUz/CnbNl3iJwZRxMrSqxsyp7jx0f g/t903ItkhiEVo2DrupFM7faoTX7/DPcXhBh/bkr20Ay+uNKYZumDkMyBSpawM5raK Ut+5vnDGc2C1sPQD75jm/n63pJiamwi58eI2wR3M3lVdk6xTR5vMn3Ur4QTOlkun8B BK41Buv9qow1NTThvM4tSiBT0cMpdhUu2SLkRibN1ROgpuegs2ZYg313l0II/8FbH3 cxXTeCHYfJOYg== Date: Mon, 23 Dec 2024 09:12:14 +0200 From: Mike Rapoport To: Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, Xi Ruoyao Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface Message-ID: References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241222_231251_004340_2BDE51BF X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > > Changelog: > ---------- > v1: initial version > v2: add __memblock_alloc_or_panic support panic output caller > v3: panic output phys_addr_t use printk's %pap > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > v6: Fix CI compile error > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@intel.com/ > v6: Fix CI compile warinigs > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@intel.com/ > v7: add chagelog and adjust function declaration alignment format > ---------- > > Signed-off-by: Guo Weikang > Reviewed-by: Andrew Morton > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Mike Rapoport (Microsoft) > Acked-by: Xi Ruoyao If people commented on your patch it does not mean you should add Reviewed-by or Acked-by tags for them. Wait for explicit tags from the reviewers. And don't respin that often, "Reviewers are busy people and may not get to your patch right away" [1]. [1] https://docs.kernel.org/process/submitting-patches.html -- Sincerely yours, Mike.