From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23CB5C27C77 for ; Mon, 17 Jun 2024 07:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=EDymHuuEk4Ux0s4bZrkBaNcQBd +91d2nCHUNE2MSohqVEedz2ED2ikEM42Th04+GK5Ca3h4/FU8BqjwNRSZbUImOfu5rhdCqqig64LQ QI6ngs72P+RejWWCMEdXzgIc6YYCtZRK3PEcWzve2+q2EXmnZZJ0jdr7xOxGpaiwxgCLigpLMJVMo XT3qq1/thfASsEIvf4hwHLi2OAL/BHhqLg0UvQGuC5k0miQVSdpBrF3E6Sj2GzuSs5z4uoJmKu0Uu 6KY8KcZ6bYfhDR94PpF7t4LkB/8IA6SICJ4OAr+hxPhJqEjw6otFwEuEFwYBMr/u09LQrfq2LtJua dBN90Qzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ7Da-00000009kzz-2uFB; Mon, 17 Jun 2024 07:55:58 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ7DX-00000009kyc-0pLE for linux-um@lists.infradead.org; Mon, 17 Jun 2024 07:55:57 +0000 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4421c014b95so20836141cf.0 for ; Mon, 17 Jun 2024 00:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1718610952; x=1719215752; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=kde2Gi0dzGwmVuH61qNvwqRS6KjJ9M3gjKx4o5AlmgKD43mlJj2kwo+sqfJNDfOIT4 BfG7Co85W89bNm96HwWHLkkJtbVxrWyP7VGWeZqvniqqaqC1atqP0+VptFJ7PZOUhUp1 i5oEBtsbO62FDSKfncOB57UsDm2xNxURwXKyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718610952; x=1719215752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=o3yRE5D7efdkuo1lwfLmL+EBtRQpI3hWjHNT3+hXF5sCQig+ggluG1+v2FFcU5Jyr4 fBMz0cTl/3ofzqMYqEll+uEVgYlaOCbRKm5SXug8Zo5To/eNwyaTNsr9L1lL1d8rnAxL DBEsKORE85kFeZw1/UHEuWG/d+NFaTsdURl3MfdPwpVxiTXFaspVA/6ENtCBWyYWObfm 3NtcGLTioovjv9CELWdtbkF3yB8lOLSTM16acAivbV3y3OStxnMZZfkIbaXfo3hNTXXA aNaZPQZMAveASGhoyJ8M3UFgVpje686cp9H4YohLXexm7j0EwOhLlNkzDfFvJ+3dGXKZ TzWA== X-Forwarded-Encrypted: i=1; AJvYcCVcuvzsiJq3g63sxRD8VCuGOAu+AEa/+JoudGBQ1oOssFAS5zbg1u8Tz5iNMQhI3nyqz6/xKnah2sqsuXBm0tzEHFAmEEFNkBvzGIY5 X-Gm-Message-State: AOJu0YyUIcTamOysa5l8CKdBJ0yTdX8yO5pfPNE/4ilFHw3NBbApiq1T Ps3sJe9wb8V2VIz97Ypn9HySFSoWIjpWOCGZCxF6xYxN9Rzd9IPR7iaRUpyLg18= X-Google-Smtp-Source: AGHT+IFxBb+fxu+zFP9/mPYH5nZSCdE6S/NGqQ55TdkfvSsNQ6okiuS1Itv2iysUUW0wZGmJIGDYbg== X-Received: by 2002:ac8:5e11:0:b0:440:10be:3ecf with SMTP id d75a77b69052e-4417ac402c0mr199666251cf.22.1718610952095; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Received: from localhost ([213.195.124.163]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef4eefaesm44094171cf.21.2024.06.17.00.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 00:55:51 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Cc: Jens Axboe , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617060532.127975-2-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_005555_248603_4A3BD523 X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to freeze the queue for that. Instead handle the case > of the feature flags cleared inside of blkfront. This removes old > debug code to check for such a mismatch which was previously impossible > to hit, including the check for passthrough requests that blkfront > never used to start with. > > Signed-off-by: Christoph Hellwig Acked-by: Roger Pau Monné Thanks, Roger.