From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5204C77B7A for ; Wed, 7 Jun 2023 13:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/WGyRdmKfouMVEjQGVMB0xs1hxztZ+37l3oSMn9cb+o=; b=w/AAX48q4oJ4EA f8PbycQyzyvemxAgaEd2RnPbdb2DU/vpLpPLxx6Ky2axnwysrqG6GNOpk8z/qTy/EzhC13qt1wup9 KPASZmVfmcqXJXe0WpQwkzi5ZM8nOzSYCwvTI6R3uuyuAq+0iC2wRlS3LAZ0EYMl9LG2RGYXnADSU 2gWrnq9l1QHVHn33mg4whgAyfQet3dCyLOfy/+FM//CJw+Su90myLnwJGyTQUhjFwTyvkWdWJlJbN M/+J3luh/jkaQIewK9SA1ueQ7onuF6ZmVweqy535RIXyWeTeAcxYbleIr/EJ3cRtJxzVbWLLN3ajT dm3OcpXMUVoCaEPWUU1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6sqN-00604U-1C; Wed, 07 Jun 2023 13:04:55 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6sqJ-00602o-17; Wed, 07 Jun 2023 13:04:52 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 826B9219F8; Wed, 7 Jun 2023 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143089; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=LDzG/FZX8+A749MhkfcbaO0/pSl5XzJ9kizkc2BlHr+CJ0OvB7HA+RE7WXn85KrExl92Os IzQkcBtxo9jxjym01y9CCeiH3S0xsnZG08hq3s27jGEDDyzfepQigu3EzmnUJttRWq9Q0r gLAzr1Smr57HQC2DT6141ezeh6kWY2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143089; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=aPV7dc8iqJjc6zRUQ4+/5tAxmJb5wPICstK1ajAOs5PwpnlIv8obvFxDXAQKxOl16Ptol8 uk8KJ6nLnB0CvoCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 429DE1346D; Wed, 7 Jun 2023 13:04:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4Da0D3GAgGTxWgAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:04:49 +0000 Message-ID: Date: Wed, 7 Jun 2023 15:04:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-21-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-21-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_060451_530077_E0C6D1F9 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/ch.c | 3 ++- > drivers/scsi/scsi_ioctl.c | 34 +++++++++++++++++----------------- > drivers/scsi/sd.c | 2 +- > drivers/scsi/sg.c | 5 +++-- > drivers/scsi/sr.c | 2 +- > drivers/scsi/st.c | 2 +- > include/scsi/scsi_ioctl.h | 2 +- > 7 files changed, 26 insertions(+), 24 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um