Re: [PATCH RFC 07/11] um: add TIMETRAVEL_REQUEST handler to request latest event

Johannes Berg
2023-11-10T17:19:09Z

On Fri, 2023-11-10 at 17:23 +0100, Benjamin Beichler wrote:
> Am 06.11.2023 um 21:33 schrieb Johannes Berg:
> > ________________________________
> >
> > On Fri, 2023-11-03 at 16:41 +0000, Benjamin Beichler wrote:
> > > Allow the so called Calendar (or simulation master) to request the
> > > latest timetravel event. This can be used in situations, where the
> > > former request message from UML to Calendar was missed.
> > How ... is it possible to _miss_ a message?! It must've even sent an ACK
> > to it...?
> I must admit, this patch is older than those for protecting the event
> list. I think mostly I mean here, the UM-instance miss to send the
> current request, not that the calendar missed it :-)

Oh. I think we should rather fix that bug though. I don't think we've
observed it.

I'm not entirely opposed to this, but relying on it for correctness
seems wrong.

Also, I've referred to it before, but with the shared memory the whole
thing kind of goes away anyway since we just write the (earliest)
request into the shared memory.

Maybe if not many kids come singing tonight I'll try to send out some
more patches ;)

johannes