From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVjCv-0004UR-3g for linux-um@lists.infradead.org; Tue, 28 May 2019 21:00:30 +0000 Message-ID: Subject: TRACE_IRQFLAGS_SUPPORT seems incomplete From: Johannes Berg Date: Tue, 28 May 2019 23:00:21 +0200 Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: linux-um@lists.infradead.org, Richard Weinberger Cc: j@w1.fi Hi, Now I've tried for a while ... but can't figure it out. It looks like TRACE_IRQFLAGS_SUPPORT is incomplete, we're getting lots of warnings like [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:4220 check_flags+0xa4/0x255 [ 0.000000] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) [ 0.000000] Call Trace: [ 0.000000] [<60047243>] show_stack+0x13b/0x155 [ 0.000000] [<60521206>] dump_stack+0x2a/0x2c [ 0.000000] [<600652af>] __warn+0x10c/0x151 [ 0.000000] [<6006538b>] warn_slowpath_fmt+0x97/0x99 [ 0.000000] [<600a3355>] check_flags+0xa4/0x255 [ 0.000000] [<600a554e>] lock_acquire+0x6c/0x1a0 [ 0.000000] [<60539298>] _raw_spin_lock+0x30/0x83 [ 0.000000] [<600b6d41>] handle_edge_irq+0x23/0x13d [ 0.000000] [<600b2b17>] generic_handle_irq+0x23/0x27 [ 0.000000] [<600454ab>] do_IRQ+0x39/0x54 [ 0.000000] [<6004556d>] sigio_handler+0xa7/0x111 [ 0.000000] [<6005badf>] sig_handler_common+0xa9/0xbf [...] [ 0.000000] possible reason: unannotated irqs-off. I've tried to put the right trace_irqflags_{on,off} calls in places like sig_handler_common(), but I can only seem to shift the warning around. Has anyone looked at this? You need to enable CONFIG_PROVE_LOCKING, CONFIG_DEBUG_LOCKDEP and CONFIG_TRACE_IRQFLAGS for this to show up, but I think Jouni had some others that might be related, without having enabled CONFIG_DEBUG_LOCKDEP. Thanks, johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um