From: Johannes Berg <johannes@sipsolutions.net>
To: Hajime Tazaki <thehajime@gmail.com>, linux-um@lists.infradead.org
Cc: ricarkol@google.com, Liam.Howlett@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v11 10/13] um: nommu: a work around for MMU dependency to PCI driver
Date: Thu, 18 Sep 2025 10:30:22 +0200 [thread overview]
Message-ID: <a58620ecefa207e141a435c36492647c3d5bd3df.camel@sipsolutions.net> (raw)
In-Reply-To: <4a9dde10c586883d20a8201ca7d76e6d7d52eaf4.1758181109.git.thehajime@gmail.com>
On Thu, 2025-09-18 at 16:39 +0900, Hajime Tazaki wrote:
> The commit 8fe743b5eba0 ("PCI: Add CONFIG_MMU dependency") restricts the
> PCI base driver to depend on MMU. While nommu UML _can_ implement PCI
> drivers over PCI devices (e.g., virtio-pci), the current nommu UML
> doesn't implement it.
>
> But without PCI drivers kunit complains as config for kunit
> (arch_uml.config) defines the dependency to PCI drivers.
>
> This commit fixes the issue of this compile failures when building PCI
> drivers with nommu UML. In particular, the fix is to undefine the
> constant PCI_IOBASE to be able to bypass pci_unmap_iospace() call.
This doesn't make a lot of sense to me. Why would we even want to build
PCI on NOMMU-UML if PCI in general is dependent on MMU now?
It's not like ARCH=um with PCI and NOMMU has any value even for testing
if such a configuration cannot exist in reality?
johannes
next prev parent reply other threads:[~2025-09-18 8:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 7:38 [PATCH RESEND v11 00/13] nommu UML Hajime Tazaki
2025-09-18 7:38 ` [PATCH RESEND v11 01/13] x86/um: nommu: elf loader for fdpic Hajime Tazaki
2025-09-18 7:38 ` [PATCH RESEND v11 02/13] um: decouple MMU specific code from the common part Hajime Tazaki
2025-09-18 7:38 ` [PATCH RESEND v11 03/13] um: nommu: memory handling Hajime Tazaki
2025-09-18 7:38 ` [PATCH RESEND v11 04/13] x86/um: nommu: syscall handling Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 05/13] um: nommu: seccomp syscalls hook Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 06/13] x86/um: nommu: process/thread handling Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 07/13] um: nommu: configure fs register on host syscall invocation Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 08/13] x86/um/vdso: nommu: vdso memory update Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 09/13] x86/um: nommu: signal handling Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 10/13] um: nommu: a work around for MMU dependency to PCI driver Hajime Tazaki
2025-09-18 8:30 ` Johannes Berg [this message]
2025-09-19 0:03 ` Hajime Tazaki
2025-09-19 7:24 ` Johannes Berg
2025-09-19 9:32 ` Hajime Tazaki
2025-09-19 9:38 ` Johannes Berg
2025-09-19 9:38 ` Johannes Berg
2025-09-19 9:43 ` Johannes Berg
2025-09-19 23:46 ` Hajime Tazaki
2025-09-22 6:32 ` Johannes Berg
2025-09-23 23:44 ` Hajime Tazaki
2025-09-23 15:42 ` Geert Uytterhoeven
2025-09-23 17:13 ` Johannes Berg
2025-09-23 23:51 ` Hajime Tazaki
2025-09-24 8:02 ` Geert Uytterhoeven
2025-09-24 11:03 ` Arnd Bergmann
2025-09-24 23:27 ` Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 11/13] um: change machine name for uname output Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 12/13] um: nommu: add documentation of nommu UML Hajime Tazaki
2025-09-18 7:39 ` [PATCH RESEND v11 13/13] um: nommu: plug nommu code into build system Hajime Tazaki
2025-09-18 10:39 ` [PATCH RESEND v11 00/13] nommu UML Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a58620ecefa207e141a435c36492647c3d5bd3df.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=ricarkol@google.com \
--cc=thehajime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).