From: Sasha Levin <sashal@kernel.org>
To: Tiwei Bie <tiwei.btw@antgroup.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
richard@nod.at, anton.ivanov@cambridgegreys.com,
johannes@sipsolutions.net, benjamin.berg@intel.com,
linux-um@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.13 23/28] um: Rewrite the sigio workaround based on epoll and tgkill
Date: Sun, 27 Apr 2025 20:00:21 -0400 [thread overview]
Message-ID: <aA7FFcn6gjIC8jCe@lappy> (raw)
In-Reply-To: <621e867f-5427-4062-8783-e474e3dcdb3f@antgroup.com>
On Tue, Apr 08, 2025 at 12:38:12PM +0800, Tiwei Bie wrote:
>On 2025/4/8 02:12, Sasha Levin wrote:
>> From: Tiwei Bie <tiwei.btw@antgroup.com>
>>
>> [ Upstream commit 33c9da5dfb18c2ff5a88d01aca2cf253cd0ac3bc ]
>>
>> The existing sigio workaround implementation removes FDs from the
>> poll when events are triggered, requiring users to re-add them via
>> add_sigio_fd() after processing. This introduces a potential race
>> condition between FD removal in write_sigio_thread() and next_poll
>> update in __add_sigio_fd(), and is inefficient due to frequent FD
>> removal and re-addition. Rewrite the implementation based on epoll
>> and tgkill for improved efficiency and reliability.
>>
>> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
>> Link: https://patch.msgid.link/20250315161910.4082396-2-tiwei.btw@antgroup.com
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> arch/um/drivers/random.c | 2 +-
>> arch/um/drivers/rtc_user.c | 2 +-
>> arch/um/include/shared/os.h | 2 +-
>> arch/um/include/shared/sigio.h | 1 -
>> arch/um/kernel/sigio.c | 26 ---
>> arch/um/os-Linux/sigio.c | 330 +++++----------------------------
>> 6 files changed, 47 insertions(+), 316 deletions(-)
>
>Please drop this patch. Thanks! Details can be found here:
>
>https://lore.kernel.org/linux-um/ffa0b6af-523d-4e3e-9952-92f5b04b82b3@antgroup.com/
Dropped, thanks.
--
Thanks,
Sasha
prev parent reply other threads:[~2025-04-28 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250407181224.3180941-1-sashal@kernel.org>
2025-04-07 18:12 ` [PATCH AUTOSEL 6.13 20/28] um: work around sched_yield not yielding in time-travel mode Sasha Levin
2025-04-07 18:12 ` [PATCH AUTOSEL 6.13 22/28] um: Switch to the pthread-based helper in sigio workaround Sasha Levin
2025-04-08 4:37 ` Tiwei Bie
2025-04-07 18:12 ` [PATCH AUTOSEL 6.13 23/28] um: Rewrite the sigio workaround based on epoll and tgkill Sasha Levin
2025-04-08 4:38 ` Tiwei Bie
2025-04-28 0:00 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA7FFcn6gjIC8jCe@lappy \
--to=sashal@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=benjamin.berg@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=tiwei.btw@antgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).