From: Ingo Molnar <mingo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>, lkp <lkp@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
linux-um@lists.infradead.org
Subject: Re: [PATCH -v2] accel/habanalabs: Don't build the driver on UML
Date: Thu, 8 May 2025 11:03:29 +0200 [thread overview]
Message-ID: <aBxzYZoPyATllU9c@gmail.com> (raw)
In-Reply-To: <709b486f4cfb93e0feac12300e4f06a34f49fd27.camel@sipsolutions.net>
* Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2025-05-08 at 10:57 +0200, Ingo Molnar wrote:
> > >
> > > I dunno. I guess we can put rdtsc() into UML on x86 as I suggested about
> > > the file placement, or we can also just fix the Kconfig there.
> >
> > The Kconfig solution looks much simpler to me too :)
> >
> > Patch attached, does this look good to you?
>
> Yeah looks good to me. Common gotcha really.
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Thanks, applied to tip:x86/msr.
> If anyone _really_ needs to have this driver built on UML (say for
> simulations/testing, we do build iwlwifi for all the time), then
> they'd probably want to replace the rdtsc() anyway with something
> else there.
Yeah.
Ingo
prev parent reply other threads:[~2025-05-08 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202505080003.0t7ewxGp-lkp@intel.com>
[not found] ` <174664324585.406.10812098910624084030.tip-bot2@tip-bot2>
2025-05-07 20:36 ` [tip: x86/msr] um: Add UML version of <asm/tsc.h> to define rdtsc() Johannes Berg
2025-05-08 8:57 ` [PATCH -v2] accel/habanalabs: Don't build the driver on UML Ingo Molnar
2025-05-08 9:02 ` Johannes Berg
2025-05-08 9:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBxzYZoPyATllU9c@gmail.com \
--to=mingo@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=lkp@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).