From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 06/12] microblaze: use pgtable-nopmd instead of 4level-fixup References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-7-git-send-email-rppt@kernel.org> From: Michal Simek Message-ID: Date: Fri, 25 Oct 2019 10:24:30 +0200 MIME-Version: 1.0 In-Reply-To: <1571822941-29776-7-git-send-email-rppt@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Richard Weinberger , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport List-ID: Hi Mike, On 23. 10. 19 11:28, Mike Rapoport wrote: > From: Mike Rapoport > > microblaze has only two-level page tables and can use pgtable-nopmd and > folding of the upper layers. > > Replace usage of include/asm-generic/4level-fixup.h and explicit definition > of __PAGETABLE_PMD_FOLDED in microblaze with > include/asm-generic/pgtable-nopmd.h and adjust page table manipulation > macros and functions accordingly. > > Signed-off-by: Mike Rapoport > --- > arch/microblaze/include/asm/page.h | 3 --- > arch/microblaze/include/asm/pgalloc.h | 16 ---------------- > arch/microblaze/include/asm/pgtable.h | 32 ++------------------------------ > arch/microblaze/kernel/signal.c | 10 +++++++--- > arch/microblaze/mm/init.c | 7 +++++-- > arch/microblaze/mm/pgtable.c | 13 +++++++++++-- > 6 files changed, 25 insertions(+), 56 deletions(-) I have take a look at this and when this is applied on the top of 5.4-rc2 there is not a problem. But as was reported by 0-day there is compilation issue on the top of mmotm/master tree and I am able to replicate it. It means there are other changes in Andrew's tree which are causing it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs