From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15685CD5BB1 for ; Thu, 21 May 2026 13:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tqeEG6FXEKElqAGUt/Z2qfbIbuB++N7b4Fh1Zt6D5dk=; b=xon3p5vjic7MsewfKxrjN0WvFs Zcof3Iv/cJhKpDmGY2Jxf6VjTYfbORgyLev2AovFmpe2L0Zw1/lfv/ztEgWJIoeB76S/GJdH97es2 mD+KW4eJZcLDtMwq3tS/HJ12AFtFPrfFR87okr8Iop5f4vSfrWufRZTxrXkBOyT4XnfGzwMtyKslu Fe/6CmE393gs1H5oPikxgJgJyBVuRioIAIuEIdceV3xIKXp/iF9WoCNbmMpRdP1BEzzpToy0D8Uwy Yl+XV+P+gNuDE9VnW3JNTjQZQx0k/BdL6gnm98Jmgwr/1P/U9KCpKk98TjUc4xF9FyrnVYoXaSTK6 bS+ES+Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ3w3-00000007yYo-25MM; Thu, 21 May 2026 13:59:39 +0000 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ3w0-00000007yXS-25sk for linux-um@lists.infradead.org; Thu, 21 May 2026 13:59:38 +0000 Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-c8279604464so9098298a12.1 for ; Thu, 21 May 2026 06:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779371975; x=1779976775; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tqeEG6FXEKElqAGUt/Z2qfbIbuB++N7b4Fh1Zt6D5dk=; b=LI0yM81CWLxgEPsJ3HHA47GV6/uSG7Gf773XW/cTs7rBbKHnC6pZg6gMkFyYbcJhIn lyqlxHtn4ZP7DrVjpOr4WqpTll8k1wEq0U9ToKhVyanO/Qf+SSHBt+1lH1zq9abpBDJS g+NmfNjqI4CdNGXWRpVXTjSFuLGoS1cYx+Y7w0QkcXUNl1mGJhr20cabo0tSDcChGq4p JcXAr2PdXkyab5RDz8zr1Jd4uonReXIaAnlkqB45MYtukNMODAzrS7yzS5DnCVCbuy4e dFLdsdxwXTXTj58igx3NEMjXo8zL+CLXtDHkqRmz8iNVsiaZvS2XzSoao+sqtOwGlnuK tbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779371975; x=1779976775; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tqeEG6FXEKElqAGUt/Z2qfbIbuB++N7b4Fh1Zt6D5dk=; b=GtFiKVxeZtRlrq8eNFSo5OnZYTequpnbPpMCJhJ1QBrsgQeT2SGZlsrZ3ffm0jy1yM J3AwH7XVq1y5zQPmes6eIlsTjAkymyiLAo0S+1gIjxskyBMbyB2zWs77ihEAHGI64U5R J9JY4Lthqi3jEqf1NVHqDP4YhyDtrKSD+oy0olzS8cpLrYesl2JtL2Vp4WXPLeziJmn4 43FDwpg/hHAVLJ5FMIgp2Dk3DH+cfhHm32ZOEIMWARuaxuJdYGa7ciyu7WLXbAPlbzLV jIbkIPqem4ltMvljJDBTNOcDuhsdElgpFT+zCjYdpb212IIyVSr57qN+0xj+JHZzkxaB GEMw== X-Forwarded-Encrypted: i=1; AFNElJ+wbdkDjQrUKjN1sgjCuwHxyA09Ls084SeRxMCRMH1NVDPwHN9UaEJ9vVqjY0p4Mj7i8ydcasjpqQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yx0HfVq82BekWpGDWtHTF0GA3GxbmAaid9eqk/VZSGrYA3v4+Ae OxFXDHf7R5WljXk+fThrMvUG1sxMpfJUNkSzLtB06BblS0K4Ik7Qpigqu3SsBwAsAvS4lIObXv2 NEd+O6w== X-Received: from pge1.prod.google.com ([2002:a05:6a02:2d01:b0:c79:83b3:cdf8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:431a:b0:39c:a78e:dba9 with SMTP id adf61e73a8af0-3b308ac1b14mr3725831637.40.1779371973881; Thu, 21 May 2026 06:59:33 -0700 (PDT) Date: Thu, 21 May 2026 06:59:33 -0700 In-Reply-To: <20260521133326.2465264-4-kees@kernel.org> Mime-Version: 1.0 References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-4-kees@kernel.org> Message-ID: Subject: Re: [PATCH 04/11] treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS From: Sean Christopherson To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , "Eugenio =?utf-8?B?UMOpcmV6?=" , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , "Ilpo =?utf-8?B?SsOkcnZpbmVu?=" , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260521_065936_548594_13CD4C9A X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Thu, May 21, 2026, Kees Cook wrote: > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > for example: > > @@ > declarer name DEFINE_KERNEL_PARAM_OPS; > identifier OPS; > expression SET, GET; > @@ > - const struct kernel_param_ops OPS = { > - .set = SET, > - .get = GET, > - }; > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); IMO, "OPS, GET, SET" is more intuitive, especially since that's the order used by DEFINE_SIMPLE_ATTRIBUTE and DEFINE_DEBUGFS_ATTRIBUTE.