linux-um archives
 help / color / mirror / Atom feed
From: Steve VanDeBogart <vandebo-lkml@NerdBox.Net>
To: linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net, jiayingz@google.com,
	dkegel@google.com
Subject: [uml-devel] [PATCH 2/6] UML: Don't valgrind userspace
Date: Fri, 29 Aug 2008 16:15:24 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.1.00.0808291614430.15543@abydos.NerdBox.Net> (raw)
In-Reply-To: <alpine.DEB.1.00.0808281139420.15543@abydos.NerdBox.Net>

Add a flag to tell Valgrind to run the forked child natively.  Necessary
because Valgrind makes additional system calls to instrumented processes,
which confuse UML.

Signed-off-by: Steve VanDeBogart <vandebo-lkml@nerdbox.net>
---

Index: linux-2.6.27-rc5/arch/um/os-Linux/skas/process.c
===================================================================
--- linux-2.6.27-rc5.orig/arch/um/os-Linux/skas/process.c	2008-08-29 15:50:24.000000000 -0700
+++ linux-2.6.27-rc5/arch/um/os-Linux/skas/process.c	2008-08-29 15:51:45.000000000 -0700
@@ -26,6 +26,7 @@
  #include "skas_ptrace.h"
  #include "user.h"
  #include "sysdep/stub.h"
+#include "valgrind.h"

  int is_skas_winch(int pid, int fd, void *data)
  {
@@ -297,8 +298,12 @@
  	flags = CLONE_FILES;
  	if (proc_mm)
  		flags |= CLONE_VM;
-	else
+	else {
  		flags |= SIGCHLD;
+#ifdef UML_CONFIG_VALGRIND_SUPPORT
+		flags |= VALGRIND_CLONE_LETGO;
+#endif
+	}

  	pid = clone(userspace_tramp, (void *) sp, flags, (void *) stub_stack);
  	if (pid < 0) {

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  parent reply	other threads:[~2008-08-29 23:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 23:12 [uml-devel] [PATCH 0/6] support valgrinding uml Steve VanDeBogart
2008-08-29 23:14 ` [uml-devel] [PATCH 1/6] base: Valgrind headers and Kconfig Steve VanDeBogart
2008-09-01  9:32   ` Andi Kleen
2008-09-01 14:06     ` Jeff Dike
2008-09-01 14:22       ` Andi Kleen
2008-09-01 15:47         ` Jeff Dike
2008-08-29 23:15 ` Steve VanDeBogart [this message]
2008-09-05 16:37   ` [uml-devel] [PATCH 2/6] UML: Don't valgrind userspace Jeff Dike
2008-09-06 20:55     ` John Reiser
2008-09-06 22:12       ` Jeff Dike
2008-08-29 23:16 ` [uml-devel] [PATCH 3/6] UML and sched: Annotate stacks Steve VanDeBogart
2008-08-29 23:16 ` [uml-devel] [PATCH 4/6] VM: Annotate pagealloc Steve VanDeBogart
2008-08-30 10:57   ` Pekka Enberg
2008-09-03  5:25     ` Steve VanDeBogart
2008-09-03  9:35       ` Pekka Enberg
2008-08-29 23:17 ` [uml-devel] [PATCH 5/6] slab: Annotate slab Steve VanDeBogart
2008-08-30 10:50   ` Pekka Enberg
2008-09-03  2:54     ` John Reiser
2008-09-03  9:39       ` Pekka J Enberg
2008-09-03  5:08     ` Steve VanDeBogart
2008-09-03  9:27       ` Pekka Enberg
2008-09-03  9:40         ` Pekka Enberg
2008-09-03 15:42         ` Steve VanDeBogart
2008-09-04  7:33           ` Pekka Enberg
2008-08-29 23:18 ` [uml-devel] [PATCH 6/6] VM: Annotate vmalloc Steve VanDeBogart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0808291614430.15543@abydos.NerdBox.Net \
    --to=vandebo-lkml@nerdbox.net \
    --cc=dkegel@google.com \
    --cc=jiayingz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox