From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B903C61DBE for ; Tue, 25 Aug 2026 13:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j3O0jUa3F64kLLrL5LogQDPv2j12GdtTejlIkXela4M=; b=o8kkNhVCzZAskKX2Q+gVfUzPxb Wu/AQXO7JW+dIvujmVIR3as2BcB+s/t8XRh++tc4T8htbtIGprnfHZUnGwDcI14wz5Pc2X7iF4jIR MzCBo/9nLdMeEQ7r0jm4Tbh8V9z9iWuKtIYe6vftD7HaCjqwXWHQFdkvlmVJYV1mD1WJDO+3AaPJX bZDe+W4oC8w5rlYR2Rvj88xTCMC8p1Js/5EwHAcHjNuabwpkLchXD+/S4a/QqMDT8SpS/c9RhEt0g Tr/HtVQz6GQqvWk3TJBJ/2pL+gzbSRUsaxfz2J+ly13ps/fQI77kFxIpEc35S5e2jqnzPALU/7CuC GVxgxT+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wyrKL-00000000sSg-1YpH; Tue, 25 Aug 2026 13:36:33 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wyrKJ-00000000sSU-3O2t for linux-um@lists.infradead.org; Tue, 25 Aug 2026 13:36:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D3F2D6011F; Tue, 25 Aug 2026 13:36:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 996F61F000E9; Tue, 25 Aug 2026 13:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787664990; bh=j3O0jUa3F64kLLrL5LogQDPv2j12GdtTejlIkXela4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=bL/6T7PtIl1SE4jX/P04Rg3Ro8uDMTXBR+IfVYE+x9UAvjV6ffKU5KIi2UYbb2Azk p5jWRud8g9M6fKt/WdbCiANY8IOY6E0GO9tF+/y3HH2CIDHPBZRk4lM4v8EXdA9xIV vvdmBV3MJpokO9m4uxF0kV9DadEr5xUgE4g1MEcQyIKv4p2QffHM5m8kqMZ5wAcpr1 1OFmbyY/SJk7SamSMGhyjmip1vkbS4m5jfEpR9huTf9xGy3VQG/pSuJr6VdL+amyfz 85Uhn+kpEjV22Ml8U417c58fgjFzYStIqvm9LlIaMeR72+D3VnMuYgSB9ZwSdjt5wy 9BywduZwpF00A== Date: Tue, 25 Aug 2026 14:36:22 +0100 From: "Lorenzo Stoakes (ARM)" To: Hajime Tazaki Cc: linux-mm@kvack.org, liam@infradead.org, rbm@suse.com, akpm@linux-foundation.org, luto@amacapital.net, brendan.jackman@linux.dev, david@kernel.org, liuhangbin@gmail.com, corbet@lwn.net, kees@kernel.org, broonie@kernel.org, mhocko@suse.com, rppt@kernel.org, shuah@kernel.org, surenb@google.com, vbabka@kernel.org, wad@chromium.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-um@lists.infradead.org, geert@linux-m68k.org, daniel@thingy.jp Subject: Re: [PATCH v2 1/2] selftests: run tests on nommu architecture Message-ID: References: <20260825015945.141739-1-thehajime@gmail.com> <20260825015945.141739-2-thehajime@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825015945.141739-2-thehajime@gmail.com> X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Tue, Aug 25, 2026 at 10:59:44AM +0900, Hajime Tazaki wrote: > Architectures lacks MMU doesn't support fork(2) syscall and only > vfork(2) is available with limitations. Thus, we cannot run kselftest > on nommu architecture as is. > > This commit addresses this issue with the following changes: > > - on build stage, add -DCONFIG_NOMMU to CFLAGS when NOMMU=1 variable > added to the build/make argument. > - on test run stage, avoid calling timeout command when NOMMU=1 variable > added to environmental variable, since timeout command uses fork > syscall which nommu platform doesn't support. > - kselftest_harness.h: skip the tests if the file is include when > executing on NOMMU platform, as there is no fork(2) syscall. > - replace "cd -" use as it is not available a shell supported on nommu > (e.g., busybox hush), use cd "$OLDDIR" instead. > - describe the difference of nommu tests in the document. > > So command line to build/execute tests for nommu should be like below: > > $ make ARCH=um NOMMU=1 O=build kselftest-all TARGETS=mm/nommu > $ make ARCH=um NOMMU=1 O=build kselftest-install TARGETS=mm/nommu > $ NOMMU=1 ./build/kselftest/kselftest_install/run_kselftest.sh -p \ > -c mm/nommu > > Cc: Shuah Khan > Cc: Jonathan Corbet > Cc: Kees Cook > Cc: Andy Lutomirski > Cc: Will Drewry > Cc: Mark Brown > Cc: Brendan Jackman > Cc: Hangbin Liu > Cc: "Ricardo B. Marliere" > Cc: linux-kselftest@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: linux-mm@kvack.org > Cc: linux-doc@vger.kernel.org > Closes: https://sashiko.dev/#/patchset/20260813063401.1786548-1-thehajime%40gmail.com > Signed-off-by: Hajime Tazaki Doesn't seem too crazy, but some nitty comments below. > > -- > > rfc => v2 > - reformat ktap header, reported by Sashiko review > > rfc: https://lore.kernel.org/linux-mm/20260813063401.1786548-1-thehajime@gmail.com/ > --- > Documentation/dev-tools/kselftest.rst | 14 ++++++++++++++ > tools/testing/selftests/kselftest/runner.sh | 9 +++++++-- > tools/testing/selftests/kselftest_harness.h | 4 ++++ > tools/testing/selftests/lib.mk | 8 ++++++++ > 4 files changed, 33 insertions(+), 2 deletions(-) > > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst > index 64c0ec7428a2..a65f3ebc5906 100644 > --- a/Documentation/dev-tools/kselftest.rst > +++ b/Documentation/dev-tools/kselftest.rst > @@ -230,6 +230,20 @@ section:: > > .. _tar's auto-compress: https://www.gnu.org/software/tar/manual/html_node/gzip.html#auto_002dcompress > > +Build and test on nommu target > +============================== > + > +If you (cross-)build kselftests for nommu targets, or run tests on nommu targets, use > +``NOMMU=1`` as a make variable/environment setting to tell build system to do the additional > +checks. These nommu targets may differ in several ways, such as not supporting fork(2) or > +using musl or another libc. Set this variable to apply the necessary build and test adjustments. > + > +:: > + > + $ make ARCH=um NOMMU=1 O=build kselftest-all TARGETS=mm/nommu # <= build-only > + $ make ARCH=um NOMMU=1 O=build kselftest-install TARGETS=mm/nommu > + $ NOMMU=1 ./build/kselftest/kselftest_install/run_kselftest.sh -p -c mm/nommu > + > Contributing new tests > ====================== > > diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh > index 311811dc55a0..7287d8290b6c 100644 > --- a/tools/testing/selftests/kselftest/runner.sh > +++ b/tools/testing/selftests/kselftest/runner.sh > @@ -38,8 +38,12 @@ tap_prefix() > > tap_timeout() > { > + # nommu doesn't support timeout command (missing fork(2)) > + if [ "$NOMMU" = "1" ] ; then > + echo "timeout isn't supported for nommu" > + $1 > # Make sure tests will time out if utility is available. > - if [ -x /usr/bin/timeout ] ; then > + elif [ -x /usr/bin/timeout ] ; then > /usr/bin/timeout --foreground "$kselftest_timeout" \ > /usr/bin/timeout "$kselftest_timeout" $1 > else > @@ -130,6 +134,7 @@ run_one() > return $KSFT_FAIL > fi > fi > + OLDDIR=$(pwd) > cd `dirname $TEST` > /dev/null > (((( tap_timeout "$cmd" 2>&1; echo $? >&3) | > tap_prefix >&4) 3>&1) | > @@ -147,7 +152,7 @@ run_one() > *) > ktap_test_fail "$TEST_HDR_MSG # exit=$rc";; > esac > - cd - >/dev/null > + cd "$OLDDIR" >/dev/null Hmm, why are you changing this bit? > fi > > return $rc > diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h > index 261e4df94d9d..0d05946a5e7a 100644 > --- a/tools/testing/selftests/kselftest_harness.h > +++ b/tools/testing/selftests/kselftest_harness.h > @@ -1274,6 +1274,10 @@ static int test_harness_run(int argc, char **argv) > unsigned int count = 0; > unsigned int pass_count = 0; > > +#ifdef CONFIG_NOMMU Let's not prefix with CONFIG_ :) I think this is pretty confusing vs. the kernel CONFIG_xxx flags, esp. as this obviously inverts CONFIG_MMU. maybe just 'NOMMU'? > + ksft_print_header(); > + ksft_exit_skip("kselftest harness requires fork(2), unavailable on NOMMU\n"); > +#endif /* CONFIG_NOMMU */ > ret = test_harness_argv_check(argc, argv); > if (ret != KSFT_PASS) > return ret; > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index f02cc8a2e4ae..fdb895967768 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -97,6 +97,14 @@ TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS)) > TEST_GEN_PROGS_EXTENDED := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS_EXTENDED)) > TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES)) > > +# detect if users request NOMMU build or not > +# User can set NOMMU to 1 to build/test for NOMMU platforms > +NOMMU ?= 0 > +ifeq ($(NOMMU),1) > +CFLAGS += -DCONFIG_NOMMU > +export NOMMU > +endif > + I wonder if this could be put into testing/selftests/nommu/something.mk? Though I guess would have to be included for all builds to account for nommu trying to build any kind of tests. > all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) \ > $(if $(TEST_GEN_MODS_DIR),gen_mods_dir) > > -- > 2.43.0 > -- Cheers, Lorenzo