From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2CC5C624D6 for ; Sat, 5 Sep 2026 11:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6Bu7zhBODPx9OVIj9kI9Cw1nNDBcCS9dXlz9GgaYwCk=; b=j+sKcvS7zQb4wW0bqeR6CzonQe kcqpIw5QgVfJJYBxHIQM6u2gzlMLrEVDSeiH5XH3NHlQXkDJJQmelpNx/fAaKnLMbKu3iwWcAasWt UBmAcWwdvQYC67lJivoAEFoI8UKmKPRWiIr7g1gKhpzYDJxDD1UF9BjbpQLbqWQD7hUbwtOfg/Bv+ ouTmhavFKTN5AKWaj2i6g2fAPMUuTm3ZW3o0fHDzXdVNA6PO5mj+edUelUxaUVoHzjurH26RE6T51 wW3KAdcoTFzy6J92huzAkR8GndGhYjdcJb+bU9r86jdiltdfk8X3DhPUZcneKmPWa69Nu4bxQEvMF mOiA6aIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2ou1-000000042HS-0ldT; Sat, 05 Sep 2026 11:49:45 +0000 Received: from submarine.notk.org ([62.210.214.84]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2otx-000000042Fk-2UNW; Sat, 05 Sep 2026 11:49:43 +0000 Received: from gaia.codewreck.org (localhost [127.0.0.1]) by submarine.notk.org (Postfix) with ESMTPS id EB42014C2D6; Sat, 5 Sep 2026 13:49:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1788608970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Bu7zhBODPx9OVIj9kI9Cw1nNDBcCS9dXlz9GgaYwCk=; b=MRiP0p+APtwWGq7nqcMTUXcXnX1Rp4Ot3CBYsNBuCSxEDHzaM37F3IZw7rUw7zihCjh19l IKEli+6W7tjafk9BZVuzO5RCsDb46aUQn0VOifmyYJXqj07Dh0YaBAgfvy4cMmotZxUc+6 gur34LYPLAa0pJP4OulRrjRHanfS9sYO8tikO2hODNpfZsJ2w6nX3QZre7n4zB4sJpxVO7 6p+3MJkGAILxtpSHRK3niKb+p+9zzn/DBBgPW0I7hvn1/aMaBuVcv6dj4bf/bQ8SDCM0Zj kpPQhAdanri4iEvqS2vR2vXhMnytBJ4tTo0nfqBJwFLeE7it5Msx3a2Er5/zRQ== Received: from localhost (gaia.codewreck.org [local]) by gaia.codewreck.org (OpenSMTPD) with ESMTPA id e27ca948; Sat, 5 Sep 2026 11:49:19 +0000 (UTC) Date: Sat, 5 Sep 2026 20:49:04 +0900 From: Dominique Martinet To: Miguel Ojeda Cc: gregkh@linuxfoundation.org, achill@achill.org, akpm@linux-foundation.org, broonie@kernel.org, conor@kernel.org, f.fainelli@gmail.com, hargar@microsoft.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux@roeck-us.net, lkft-triage@lists.linaro.org, patches@kernelci.org, patches@lists.linux.dev, pavel@nabladev.com, rwarsow@gmx.de, shuah@kernel.org, sr@sladewatkins.com, stable@vger.kernel.org, sudipm.mukherjee@gmail.com, torvalds@linux-foundation.org, David Hildenbrand , Lorenzo Stoakes , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo , Jann Horn , Lance Yang , linux-mm@kvack.org, Russell King , linux-arm-kernel@lists.infradead.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org Subject: Re: [PATCH 6.18 000/552] 6.18.50-rc1 review Message-ID: References: <20260904045747.813364717@linuxfoundation.org> <20260905114111.124795-1-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260905114111.124795-1-ojeda@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260905_044942_038074_A2924010 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org Miguel Ojeda wrote on Sat, Sep 05, 2026 at 01:41:11PM +0200: > I see the same arm32 build issue: > > mm/page_vma_mapped.c:110:11: error: call to undeclared function 'huge_ptep_get'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 110 | ptent = huge_ptep_get(pvmw->vma->vm_mm, pvmw->address, > | ^ > > In addition, in UML (x86_64) there is also nearby: > > mm/page_vma_mapped.c:110:9: error: assigning to 'pte_t' from incompatible type 'int' > 110 | ptent = huge_ptep_get(pvmw->vma->vm_mm, pvmw->address, > | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 111 | pvmw->pte); > | ~~~~~~~~~~ See this 6.12 thread[1] for this build failure (I didn't check but assume it is the same, that missing commit only made it 7.3-rc1 but was also backported to the 7.2 tree, which also explains 7.2 didn't build fail) --- This builds on master because this commit: f5407e9b697c ("mm/rmap: use huge_ptep_get() in try_to_unmap_one()") added a function declaration in linux/hugetlb.h !CONFIG_HUGETLB_PAGE code: ``` diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 817b8b4223fa..95b1b6ee1f96 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -1270,6 +1270,8 @@ static inline void hugetlb_count_sub(long l, struct mm_struct *mm) { } +pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, pte_t *ptep); + static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep) { ``` The rest of that commit isn't applicable, so we either need to roll that change in 'mm/migrate: use huge_ptep_get() in remove_migration_pte()' or add it separately (or drop that commit) --- [1] https://lore.kernel.org/r/apq_s8mFJJPzoIdo@codewreck.org -- Dominique