From: Randy Dunlap <rdunlap@infradead.org>
To: Lukas Straub <lukasstraub2@web.de>,
linux-um <linux-um@lists.infradead.org>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls_32.h
Date: Fri, 26 Aug 2022 13:37:01 -0700 [thread overview]
Message-ID: <b339d712-8229-469e-e976-6283b6fad842@infradead.org> (raw)
In-Reply-To: <20220826152927.193d262c@gecko>
On 8/26/22 08:29, Lukas Straub wrote:
> Like in f4f03f299a56ce4d73c5431e0327b3b6cb55ebb9
> "um: Cleanup syscall_handler_t definition/cast, fix warning",
> remove the cast to to fix the compiler warning.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> arch/x86/um/shared/sysdep/syscalls_32.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/syscalls_32.h b/arch/x86/um/shared/sysdep/syscalls_32.h
> index 68fd2cf526fd..f6e9f84397e7 100644
> --- a/arch/x86/um/shared/sysdep/syscalls_32.h
> +++ b/arch/x86/um/shared/sysdep/syscalls_32.h
> @@ -6,10 +6,9 @@
> #include <asm/unistd.h>
> #include <sysdep/ptrace.h>
>
> -typedef long syscall_handler_t(struct pt_regs);
> +typedef long syscall_handler_t(struct syscall_args);
>
> extern syscall_handler_t *sys_call_table[];
>
> #define EXECUTE_SYSCALL(syscall, regs) \
> - ((long (*)(struct syscall_args)) \
> - (*sys_call_table[syscall]))(SYSCALL_ARGS(®s->regs))
> + ((*sys_call_table[syscall]))(SYSCALL_ARGS(®s->regs))
--
~Randy
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2022-08-26 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 15:29 [PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls_32.h Lukas Straub
2022-08-26 20:37 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b339d712-8229-469e-e976-6283b6fad842@infradead.org \
--to=rdunlap@infradead.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=lukasstraub2@web.de \
--cc=richard@nod.at \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).