From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7CQw-003jOw-2g for linux-um@lists.infradead.org; Fri, 01 Jul 2022 08:55:27 +0000 Received: by mail-pj1-f70.google.com with SMTP id em12-20020a17090b014c00b001ed493d4f0cso1080330pjb.4 for ; Fri, 01 Jul 2022 01:55:20 -0700 (PDT) Message-ID: Date: Fri, 1 Jul 2022 16:55:05 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v11 09/40] virtio_ring: split: extract the logic of alloc state and extra References: <20220629065656.54420-1-xuanzhuo@linux.alibaba.com> <20220629065656.54420-10-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220629065656.54420-10-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com CuWcqCAyMDIyLzYvMjkgMTQ6NTYsIFh1YW4gWmh1byDlhpnpgZM6Cj4gU2VwYXJhdGUgdGhlIGxv Z2ljIG9mIGNyZWF0aW5nIGRlc2Nfc3RhdGUsIGRlc2NfZXh0cmEsIGFuZCBzdWJzZXF1ZW50Cj4g cGF0Y2hlcyB3aWxsIGNhbGwgaXQgaW5kZXBlbmRlbnRseS4KPgo+IFNpbmNlIG9ubHkgdGhlIHN0 cnVjdHVyZSB2cmluZyBpcyBwYXNzZWQgaW50byBfX3ZyaW5nX25ld192aXJ0cXVldWUoKSwKPiB3 aGVuIGNyZWF0aW5nIHRoZSBmdW5jdGlvbiB2cmluZ19hbGxvY19zdGF0ZV9leHRyYV9zcGxpdCgp LCB3ZSBwcmVmZXIgdG8KPiB1c2UgdnJpbmdfdmlydHF1ZXVlX3NwbGl0IGFzIGEgcGFyYW1ldGVy LCBhbmQgaXQgd2lsbCBiZSBtb3JlIGNvbnZlbmllbnQKPiB0byBwYXNzIHZyaW5nX3ZpcnRxdWV1 ZV9zcGxpdCB0byBzb21lIHN1YnNlcXVlbnQgZnVuY3Rpb25zLgo+Cj4gU28gYSBuZXcgdnJpbmdf dmlydHF1ZXVlX3NwbGl0IHZhcmlhYmxlIGlzIGFkZGVkIGluCj4gX192cmluZ19uZXdfdmlydHF1 ZXVlKCkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56aHVvQGxpbnV4LmFsaWJh YmEuY29tPgo+IC0tLQo+ICAgZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYyB8IDU4ICsrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQwIGlu c2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmly dGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jCj4gaW5kZXgg YTljZWI5YzE2YzU0Li5jZWRkMzQwZDZkYjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aXJ0aW8v dmlydGlvX3JpbmcuYwo+ICsrKyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiBAQCAt MjA0LDYgKzIwNCw3IEBAIHN0cnVjdCB2cmluZ192aXJ0cXVldWUgewo+ICAgI2VuZGlmCj4gICB9 Owo+ICAgCj4gK3N0YXRpYyBzdHJ1Y3QgdnJpbmdfZGVzY19leHRyYSAqdnJpbmdfYWxsb2NfZGVz Y19leHRyYSh1bnNpZ25lZCBpbnQgbnVtKTsKPiAgIAo+ICAgLyoKPiAgICAqIEhlbHBlcnMuCj4g QEAgLTkzOSw2ICs5NDAsMzIgQEAgc3RhdGljIHZvaWQgKnZpcnRxdWV1ZV9kZXRhY2hfdW51c2Vk X2J1Zl9zcGxpdChzdHJ1Y3QgdmlydHF1ZXVlICpfdnEpCj4gICAJcmV0dXJuIE5VTEw7Cj4gICB9 Cj4gICAKPiArc3RhdGljIGludCB2cmluZ19hbGxvY19zdGF0ZV9leHRyYV9zcGxpdChzdHJ1Y3Qg dnJpbmdfdmlydHF1ZXVlX3NwbGl0ICp2cmluZykKPiArewo+ICsJc3RydWN0IHZyaW5nX2Rlc2Nf c3RhdGVfc3BsaXQgKnN0YXRlOwo+ICsJc3RydWN0IHZyaW5nX2Rlc2NfZXh0cmEgKmV4dHJhOwo+ ICsJdTMyIG51bSA9IHZyaW5nLT52cmluZy5udW07Cj4gKwo+ICsJc3RhdGUgPSBrbWFsbG9jX2Fy cmF5KG51bSwgc2l6ZW9mKHN0cnVjdCB2cmluZ19kZXNjX3N0YXRlX3NwbGl0KSwgR0ZQX0tFUk5F TCk7Cj4gKwlpZiAoIXN0YXRlKQo+ICsJCWdvdG8gZXJyX3N0YXRlOwo+ICsKPiArCWV4dHJhID0g dnJpbmdfYWxsb2NfZGVzY19leHRyYShudW0pOwo+ICsJaWYgKCFleHRyYSkKPiArCQlnb3RvIGVy cl9leHRyYTsKPiArCj4gKwltZW1zZXQoc3RhdGUsIDAsIG51bSAqIHNpemVvZihzdHJ1Y3QgdnJp bmdfZGVzY19zdGF0ZV9zcGxpdCkpOwo+ICsKPiArCXZyaW5nLT5kZXNjX3N0YXRlID0gc3RhdGU7 Cj4gKwl2cmluZy0+ZGVzY19leHRyYSA9IGV4dHJhOwo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtlcnJf ZXh0cmE6Cj4gKwlrZnJlZShzdGF0ZSk7Cj4gK2Vycl9zdGF0ZToKPiArCXJldHVybiAtRU5PTUVN Owo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQgdnJpbmdfZnJlZV9zcGxpdChzdHJ1Y3QgdnJpbmdf dmlydHF1ZXVlX3NwbGl0ICp2cmluZywKPiAgIAkJCSAgICAgc3RydWN0IHZpcnRpb19kZXZpY2Ug KnZkZXYpCj4gICB7Cj4gQEAgLTIyMjQsNyArMjI1MSw3IEBAIEVYUE9SVF9TWU1CT0xfR1BMKHZy aW5nX2ludGVycnVwdCk7Cj4gICAKPiAgIC8qIE9ubHkgYXZhaWxhYmxlIGZvciBzcGxpdCByaW5n ICovCj4gICBzdHJ1Y3QgdmlydHF1ZXVlICpfX3ZyaW5nX25ld192aXJ0cXVldWUodW5zaWduZWQg aW50IGluZGV4LAo+IC0JCQkJCXN0cnVjdCB2cmluZyB2cmluZywKPiArCQkJCQlzdHJ1Y3QgdnJp bmcgX3ZyaW5nLAo+ICAgCQkJCQlzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwKPiAgIAkJCQkJ Ym9vbCB3ZWFrX2JhcnJpZXJzLAo+ICAgCQkJCQlib29sIGNvbnRleHQsCj4gQEAgLTIyMzIsNyAr MjI1OSw5IEBAIHN0cnVjdCB2aXJ0cXVldWUgKl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25l ZCBpbnQgaW5kZXgsCj4gICAJCQkJCXZvaWQgKCpjYWxsYmFjaykoc3RydWN0IHZpcnRxdWV1ZSAq KSwKPiAgIAkJCQkJY29uc3QgY2hhciAqbmFtZSkKPiAgIHsKPiArCXN0cnVjdCB2cmluZ192aXJ0 cXVldWVfc3BsaXQgdnJpbmcgPSB7fTsKCgpOaXQ6IHRvIHJlZHVjZSB0aGUgY2hhbmdlLXNldCwg bGV0J3MgdXNlIHZyaW5nX3NwbGl0IGhlcmU/CgpPdGhlciBsb29rcyBnb29kLgoKVGhhbmtzCgoK PiAgIAlzdHJ1Y3QgdnJpbmdfdmlydHF1ZXVlICp2cTsKPiArCWludCBlcnI7Cj4gICAKPiAgIAlp ZiAodmlydGlvX2hhc19mZWF0dXJlKHZkZXYsIFZJUlRJT19GX1JJTkdfUEFDS0VEKSkKPiAgIAkJ cmV0dXJuIE5VTEw7Cj4gQEAgLTIyNjEsNyArMjI5MCw3IEBAIHN0cnVjdCB2aXJ0cXVldWUgKl9f dnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25lZCBpbnQgaW5kZXgsCj4gICAJdnEtPnNwbGl0LnF1 ZXVlX2RtYV9hZGRyID0gMDsKPiAgIAl2cS0+c3BsaXQucXVldWVfc2l6ZV9pbl9ieXRlcyA9IDA7 Cj4gICAKPiAtCXZxLT5zcGxpdC52cmluZyA9IHZyaW5nOwo+ICsJdnEtPnNwbGl0LnZyaW5nID0g X3ZyaW5nOwo+ICAgCXZxLT5zcGxpdC5hdmFpbF9mbGFnc19zaGFkb3cgPSAwOwo+ICAgCXZxLT5z cGxpdC5hdmFpbF9pZHhfc2hhZG93ID0gMDsKPiAgIAo+IEBAIC0yMjczLDMwICsyMzAyLDIzIEBA IHN0cnVjdCB2aXJ0cXVldWUgKl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25lZCBpbnQgaW5k ZXgsCj4gICAJCQkJCXZxLT5zcGxpdC5hdmFpbF9mbGFnc19zaGFkb3cpOwo+ICAgCX0KPiAgIAo+ IC0JdnEtPnNwbGl0LmRlc2Nfc3RhdGUgPSBrbWFsbG9jX2FycmF5KHZyaW5nLm51bSwKPiAtCQkJ c2l6ZW9mKHN0cnVjdCB2cmluZ19kZXNjX3N0YXRlX3NwbGl0KSwgR0ZQX0tFUk5FTCk7Cj4gLQlp ZiAoIXZxLT5zcGxpdC5kZXNjX3N0YXRlKQo+IC0JCWdvdG8gZXJyX3N0YXRlOwo+ICsJdnJpbmcu dnJpbmcgPSBfdnJpbmc7Cj4gICAKPiAtCXZxLT5zcGxpdC5kZXNjX2V4dHJhID0gdnJpbmdfYWxs b2NfZGVzY19leHRyYSh2cmluZy5udW0pOwo+IC0JaWYgKCF2cS0+c3BsaXQuZGVzY19leHRyYSkK PiAtCQlnb3RvIGVycl9leHRyYTsKPiArCWVyciA9IHZyaW5nX2FsbG9jX3N0YXRlX2V4dHJhX3Nw bGl0KCZ2cmluZyk7Cj4gKwlpZiAoZXJyKSB7Cj4gKwkJa2ZyZWUodnEpOwo+ICsJCXJldHVybiBO VUxMOwo+ICsJfQo+ICAgCj4gLQltZW1zZXQodnEtPnNwbGl0LmRlc2Nfc3RhdGUsIDAsIHZyaW5n Lm51bSAqCj4gLQkJCXNpemVvZihzdHJ1Y3QgdnJpbmdfZGVzY19zdGF0ZV9zcGxpdCkpOwo+ICsJ dnEtPnNwbGl0LmRlc2Nfc3RhdGUgPSB2cmluZy5kZXNjX3N0YXRlOwo+ICsJdnEtPnNwbGl0LmRl c2NfZXh0cmEgPSB2cmluZy5kZXNjX2V4dHJhOwo+ICAgCj4gLQl2aXJ0cXVldWVfaW5pdCh2cSwg dnEtPnNwbGl0LnZyaW5nLm51bSk7Cj4gKwl2aXJ0cXVldWVfaW5pdCh2cSwgdnJpbmcudnJpbmcu bnVtKTsKPiAgIAo+ICAgCXNwaW5fbG9jaygmdmRldi0+dnFzX2xpc3RfbG9jayk7Cj4gICAJbGlz dF9hZGRfdGFpbCgmdnEtPnZxLmxpc3QsICZ2ZGV2LT52cXMpOwo+ICAgCXNwaW5fdW5sb2NrKCZ2 ZGV2LT52cXNfbGlzdF9sb2NrKTsKPiAgIAlyZXR1cm4gJnZxLT52cTsKPiAtCj4gLWVycl9leHRy YToKPiAtCWtmcmVlKHZxLT5zcGxpdC5kZXNjX3N0YXRlKTsKPiAtZXJyX3N0YXRlOgo+IC0Ja2Zy ZWUodnEpOwo+IC0JcmV0dXJuIE5VTEw7Cj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MX0dQTChfX3Zy aW5nX25ld192aXJ0cXVldWUpOwo+ICAgCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC11bQo=