From: stian@nixia.no
To: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] um: Implement probe_kernel_read()
Date: Sat, 17 Aug 2013 09:44:02 +0200 [thread overview]
Message-ID: <cae15b5bcee216a9879a11d8a219daba@nixia.no> (raw)
In-Reply-To: <1376682288-25315-1-git-send-email-richard@nod.at>
Den 2013-08-16 21:44, skrev Richard Weinberger:
> +long probe_kernel_read(void *dst, const void *src, size_t size)
> +{
> + void *psrc = (void *)rounddown((u64)src, PAGE_SIZE);
Should not size be increased if psrc is moved down?
Example:
src = 0x0ffff; // pointed to the very end of a page
size = 2; // big enough to cross two pages
psrc = 0x0f000; // pointed to the start of the first page
size = 2; // does not include the second page anymore
second page is not checked
Or is this not a problem?
Stian
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2013-08-17 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 19:44 [uml-devel] [PATCH] um: Implement probe_kernel_read() Richard Weinberger
2013-08-16 20:03 ` Richard Weinberger
2013-08-17 7:44 ` stian [this message]
2013-08-17 9:00 ` richard -rw- weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae15b5bcee216a9879a11d8a219daba@nixia.no \
--to=stian@nixia.no \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox