Comments inline

On Apr 7, 2005 7:36 AM, Blaisorblade <blaisorblade@yahoo.it> wrote:
> > > sed: -e expression #4, char 2: Extra characters after command
> > > make[1]: *** [arch/um/kernel/config.c] Error 1
> > > make: *** [arch/um/kernel] Error 2
> > >
> > > and here is the file arch/um/kernel/.config.tmp.cmd that gets created
> > > which I am guessing has the sed error
> > > cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e
> > > 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config >
> > > arch/um/kernel/config.tmp
> >
> > There is no expression #4 in that.  It has three expressions (-e arguments)
> > and a filename...
> Ian, good catch, but you're quoting the wrong .cmd file. config.tmp is built
> correctly, config.c is not, so you should quote .config.c.cmd.
> 
There is no such file as .config.c.cmd and don't see it mentioned in
Makefile either.
There is however .checksum.o.cmd (8348 bytes), config.tmp (13609
bytes) if you want to see either.

> Anyway, from looking at what you quote, it's identical to the code in
> arch/um/kernel/Makefile. Quoting the correct code:
> 
> quiet_cmd_quote2 = QUOTE   $@
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                   -e 's/"CONFIG"\;/""/'        \
>                   -e 'r $(obj)/config.tmp'     \
>                   -e 'a""\;'                   \
>                   -e '}'                       \
>                   $< > $@
> 
This matches my Makefile exactly

> As you see, there is a fourth expression, *here*. But it's -e '}'.
> 
> This patch went in after 2.6.11, I'm noticing - wow, are releases getting so
> slow?
> 
> > > System is Debian Woody,
> Can you post your sed version? and Rob, can you then test it and fix the code?

GNU sed version 3.02

> Please save the correct config.c currently created and check it for
> reference.
> > > I don't know much yet about sed or the kernel build process but can
> > > look into if nobody else makes sense of this. Just thought it was good
> > > to get it out there considering it doesn't compile and rc2 has just
> > > come out.
> 
> > I know sed.  I wrote and maintain the current busybox sed implementation.
> > I just don't know what the build's doing.
> Explained above.
> > Could you send me your .config?

Attached

> 
> > > And UML does compile under 2.6.11 with a patch for gcc
> The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's under
> review. The only problem is that somebody complains about the fact Linux
> still supports 2.95. Luckily for you, Linus already shut them off once, so
> the support won't go away soon.

Yes lucky for me as I don't have root access to my box here and can't alter....

__va_copy and systables patch (duplicated enums)

> > > (which is
> > > include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
> > > if this will help.
> You mean -rc2, ok.

Yep :-)