From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRsce-007uji-O1 for linux-um@lists.infradead.org; Wed, 09 Mar 2022 09:28:46 +0000 Received: by mail-pg1-f199.google.com with SMTP id 196-20020a6307cd000000b0038027886594so1005636pgh.4 for ; Wed, 09 Mar 2022 01:28:42 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 17:28:21 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v7 25/26] virtio_net: set the default max ring size by find_vqs() References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-26-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220308123518.33800-26-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org CuWcqCAyMDIyLzMvOCDkuIvljYg4OjM1LCBYdWFuIFpodW8g5YaZ6YGTOgo+IFVzZSB2aXJ0aW9f ZmluZF92cXNfY3R4X3NpemUoKSB0byBzcGVjaWZ5IHRoZSBtYXhpbXVtIHJpbmcgc2l6ZSBvZiB0 eCwKPiByeCBhdCB0aGUgc2FtZSB0aW1lLgo+Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICB8 IHJ4L3R4IHJpbmcgc2l6ZQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiBzcGVlZCA9PSBVTktOT1dOIG9yIDwgMTBHfCAxMDI0Cj4gc3BlZWQgPCA0MEcgICAg ICAgICAgICAgIHwgNDA5Ngo+IHNwZWVkID49IDQwRyAgICAgICAgICAgICB8IDgxOTIKPgo+IENh bGwgdmlydG5ldF91cGRhdGVfc2V0dGluZ3MoKSBvbmNlIGJlZm9yZSBjYWxsaW5nIGluaXRfdnFz KCkgdG8gdXBkYXRlCj4gc3BlZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56 aHVvQGxpbnV4LmFsaWJhYmEuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9uZXQvdmlydGlvX25ldC5j IHwgNDIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4g aW5kZXggZmZmZjMyM2RjZWYwLi5mMWJkYzZjZTIxYzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9u ZXQvdmlydGlvX25ldC5jCj4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gQEAgLTI5 NzcsNiArMjk3NywyOSBAQCBzdGF0aWMgdW5zaWduZWQgaW50IG1lcmdlYWJsZV9taW5fYnVmX2xl bihzdHJ1Y3QgdmlydG5ldF9pbmZvICp2aSwgc3RydWN0IHZpcnRxdQo+ICAgCQkgICAodW5zaWdu ZWQgaW50KUdPT0RfUEFDS0VUX0xFTik7Cj4gICB9Cj4gICAKPiArc3RhdGljIHZvaWQgdmlydG5l dF9jb25maWdfc2l6ZXMoc3RydWN0IHZpcnRuZXRfaW5mbyAqdmksIHUzMiAqc2l6ZXMpCj4gK3sK PiArCXUzMiBpLCByeF9zaXplLCB0eF9zaXplOwo+ICsKPiArCWlmICh2aS0+c3BlZWQgPT0gU1BF RURfVU5LTk9XTiB8fCB2aS0+c3BlZWQgPCBTUEVFRF8xMDAwMCkgewo+ICsJCXJ4X3NpemUgPSAx MDI0Owo+ICsJCXR4X3NpemUgPSAxMDI0Owo+ICsKPiArCX0gZWxzZSBpZiAodmktPnNwZWVkIDwg U1BFRURfNDAwMDApIHsKPiArCQlyeF9zaXplID0gMTAyNCAqIDQ7Cj4gKwkJdHhfc2l6ZSA9IDEw MjQgKiA0Owo+ICsKPiArCX0gZWxzZSB7Cj4gKwkJcnhfc2l6ZSA9IDEwMjQgKiA4Owo+ICsJCXR4 X3NpemUgPSAxMDI0ICogODsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgdmktPm1heF9x dWV1ZV9wYWlyczsgaSsrKSB7Cj4gKwkJc2l6ZXNbcnhxMnZxKGkpXSA9IHJ4X3NpemU7Cj4gKwkJ c2l6ZXNbdHhxMnZxKGkpXSA9IHR4X3NpemU7Cj4gKwl9Cj4gK30KPiArCj4gICBzdGF0aWMgaW50 IHZpcnRuZXRfZmluZF92cXMoc3RydWN0IHZpcnRuZXRfaW5mbyAqdmkpCj4gICB7Cj4gICAJdnFf Y2FsbGJhY2tfdCAqKmNhbGxiYWNrczsKPiBAQCAtMjk4NCw2ICszMDA3LDcgQEAgc3RhdGljIGlu dCB2aXJ0bmV0X2ZpbmRfdnFzKHN0cnVjdCB2aXJ0bmV0X2luZm8gKnZpKQo+ICAgCWludCByZXQg PSAtRU5PTUVNOwo+ICAgCWludCBpLCB0b3RhbF92cXM7Cj4gICAJY29uc3QgY2hhciAqKm5hbWVz Owo+ICsJdTMyICpzaXplczsKPiAgIAlib29sICpjdHg7Cj4gICAKPiAgIAkvKiBXZSBleHBlY3Qg MSBSWCB2aXJ0cXVldWUgZm9sbG93ZWQgYnkgMSBUWCB2aXJ0cXVldWUsIGZvbGxvd2VkIGJ5Cj4g QEAgLTMwMTEsMTAgKzMwMzUsMTUgQEAgc3RhdGljIGludCB2aXJ0bmV0X2ZpbmRfdnFzKHN0cnVj dCB2aXJ0bmV0X2luZm8gKnZpKQo+ICAgCQljdHggPSBOVUxMOwo+ICAgCX0KPiAgIAo+ICsJc2l6 ZXMgPSBrbWFsbG9jX2FycmF5KHRvdGFsX3Zxcywgc2l6ZW9mKCpzaXplcyksIEdGUF9LRVJORUwp Owo+ICsJaWYgKCFzaXplcykKPiArCQlnb3RvIGVycl9zaXplczsKPiArCj4gICAJLyogUGFyYW1l dGVycyBmb3IgY29udHJvbCB2aXJ0cXVldWUsIGlmIGFueSAqLwo+ICAgCWlmICh2aS0+aGFzX2N2 cSkgewo+ICAgCQljYWxsYmFja3NbdG90YWxfdnFzIC0gMV0gPSBOVUxMOwo+ICAgCQluYW1lc1t0 b3RhbF92cXMgLSAxXSA9ICJjb250cm9sIjsKPiArCQlzaXplc1t0b3RhbF92cXMgLSAxXSA9IDA7 CgoKTml0OiBEbyB3ZSBuZWVkIGEgc2FuZSB2YWx1ZSBmb3IgdGhlIGNvbnRyb2wgdnE/IChlLmcg NjQpCgpUaGFua3MKCgo+ICAgCX0KPiAgIAo+ICAgCS8qIEFsbG9jYXRlL2luaXRpYWxpemUgcGFy YW1ldGVycyBmb3Igc2VuZC9yZWNlaXZlIHZpcnRxdWV1ZXMgKi8KPiBAQCAtMzAyOSw4ICszMDU4 LDEwIEBAIHN0YXRpYyBpbnQgdmlydG5ldF9maW5kX3ZxcyhzdHJ1Y3QgdmlydG5ldF9pbmZvICp2 aSkKPiAgIAkJCWN0eFtyeHEydnEoaSldID0gdHJ1ZTsKPiAgIAl9Cj4gICAKPiAtCXJldCA9IHZp cnRpb19maW5kX3Zxc19jdHgodmktPnZkZXYsIHRvdGFsX3ZxcywgdnFzLCBjYWxsYmFja3MsCj4g LQkJCQkgIG5hbWVzLCBjdHgsIE5VTEwpOwo+ICsJdmlydG5ldF9jb25maWdfc2l6ZXModmksIHNp emVzKTsKPiArCj4gKwlyZXQgPSB2aXJ0aW9fZmluZF92cXNfY3R4X3NpemUodmktPnZkZXYsIHRv dGFsX3ZxcywgdnFzLCBjYWxsYmFja3MsCj4gKwkJCQkgICAgICAgbmFtZXMsIGN0eCwgTlVMTCwg c2l6ZXMpOwo+ICAgCWlmIChyZXQpCj4gICAJCWdvdG8gZXJyX2ZpbmQ7Cj4gICAKPiBAQCAtMzA1 MCw2ICszMDgxLDggQEAgc3RhdGljIGludCB2aXJ0bmV0X2ZpbmRfdnFzKHN0cnVjdCB2aXJ0bmV0 X2luZm8gKnZpKQo+ICAgCj4gICAKPiAgIGVycl9maW5kOgo+ICsJa2ZyZWUoc2l6ZXMpOwo+ICtl cnJfc2l6ZXM6Cj4gICAJa2ZyZWUoY3R4KTsKPiAgIGVycl9jdHg6Cj4gICAJa2ZyZWUobmFtZXMp Owo+IEBAIC0zMzY4LDYgKzM0MDEsOSBAQCBzdGF0aWMgaW50IHZpcnRuZXRfcHJvYmUoc3RydWN0 IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gICAJCXZpLT5jdXJyX3F1ZXVlX3BhaXJzID0gbnVtX29u bGluZV9jcHVzKCk7Cj4gICAJdmktPm1heF9xdWV1ZV9wYWlycyA9IG1heF9xdWV1ZV9wYWlyczsK PiAgIAo+ICsJdmlydG5ldF9pbml0X3NldHRpbmdzKGRldik7Cj4gKwl2aXJ0bmV0X3VwZGF0ZV9z ZXR0aW5ncyh2aSk7Cj4gKwo+ICAgCS8qIEFsbG9jYXRlL2luaXRpYWxpemUgdGhlIHJ4L3R4IHF1 ZXVlcywgYW5kIGludm9rZSBmaW5kX3ZxcyAqLwo+ICAgCWVyciA9IGluaXRfdnFzKHZpKTsKPiAg IAlpZiAoZXJyKQo+IEBAIC0zMzgwLDggKzM0MTYsNiBAQCBzdGF0aWMgaW50IHZpcnRuZXRfcHJv YmUoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gICAJbmV0aWZfc2V0X3JlYWxfbnVtX3R4 X3F1ZXVlcyhkZXYsIHZpLT5jdXJyX3F1ZXVlX3BhaXJzKTsKPiAgIAluZXRpZl9zZXRfcmVhbF9u dW1fcnhfcXVldWVzKGRldiwgdmktPmN1cnJfcXVldWVfcGFpcnMpOwo+ICAgCj4gLQl2aXJ0bmV0 X2luaXRfc2V0dGluZ3MoZGV2KTsKPiAtCj4gICAJaWYgKHZpcnRpb19oYXNfZmVhdHVyZSh2ZGV2 LCBWSVJUSU9fTkVUX0ZfU1RBTkRCWSkpIHsKPiAgIAkJdmktPmZhaWxvdmVyID0gbmV0X2ZhaWxv dmVyX2NyZWF0ZSh2aS0+ZGV2KTsKPiAgIAkJaWYgKElTX0VSUih2aS0+ZmFpbG92ZXIpKSB7CgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0g bWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=