From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFD88CD5BD5 for ; Mon, 25 May 2026 13:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9XVHRPBSt9KXo5wrulw6nEDVPqzcFN/DF35DZwL4F0c=; b=hqLO53SVWf4xGZOwNHzFdxcJJM Wixx492B8YBkr7y357mYWdp10c4S1vzxcelNUuTFi9SyxO+Skzy+WP68VuB8quF8yB+gADLx/cWLP fSRmaUJ6CCWD1B5x7kOPKX5ea0EiKYR0niHmJmVPtQZWbpK/m6khfIx1YkkhAOxBepKnE+wCGrUDk Vy+zluXmrrhTQ83CP4sPlafE8EGbIJKnOKLKLDEdwFWs0m9hWj5brocJHS3nZ7DkHOgqxqppusIzE 60np0C5NU1HQ27s+BpZVhCxnj6HUkY4usxVyeB7WYHY9LnBaocvUqQjSKB85XGWI+1qi7Z/OWtT8g dP45cUnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRVSb-0000000HKL6-2lz4; Mon, 25 May 2026 13:35:13 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRVSZ-0000000HKKV-3IG1 for linux-um@lists.infradead.org; Mon, 25 May 2026 13:35:13 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-441209fb77eso5927332f8f.1 for ; Mon, 25 May 2026 06:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779716110; x=1780320910; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9XVHRPBSt9KXo5wrulw6nEDVPqzcFN/DF35DZwL4F0c=; b=eHxn09ttmzi0xaJyCM4A+yTj2sJIzyr5Q49PwJWOme8BEoit43d1UQHfjJYK+5tDRy qvSdHXOW5h7gAljVOEjVcR/HorXgqBe9c9kzvSnlg9iqxRPY2ZQS4VKBUHyvrBsNtai0 /STofRBP7yBTZzYV7NzQMxNfi58uTld2fMocvmKsjZEUsQ319ExwdboTGxlPl99+7YWI AHLtp0AcGXxP99FVujxqMOhrgU5c7NHEEvqy/cD9HooL1FZQ01dfigZyfhxOBPdnzSJg iHtg5oxo3bfsxNlz4rjiLagWsAjPV63zSHE6A6HAdUZa/Vw4vbLYvIlXXA9uoGF6QJLB +/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779716110; x=1780320910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9XVHRPBSt9KXo5wrulw6nEDVPqzcFN/DF35DZwL4F0c=; b=hRiVY3r3kJhSsm2hXno+429O8mbqUQ5y0CMHemn4m6p88uFv7vAclic5gttI9E8oA5 eEvKvNGMpAT9LuG8dj2GHfU4yxMY5kbyCAtGna2zhsjM9OySFu+cs73ExHvA9Eabg1GC JMlHsjomroJGIykrjgOWBvZejm+S6/TTZcKtA+e9t1X9XM6aQei+/4yHCgi59flbNVIB 1UbEzhmnh5AJxkBQiO1jEgcER1JIC1P4kluEyzCw9a5WzN8G8DD3uDAXKR15zm9MtWCt AaE1l6Qa3mZ4fu1TG9P/1gfTJp8DNaDf8npiZA+4S30itH7O6kZ+FIZUWZ3JM6kJvgDY +pfg== X-Forwarded-Encrypted: i=1; AFNElJ81TdcNSoOuhgGGtp34+z/kl/9KP/2p3OrBeptYa0z2ivdPCjLhKGP+hyO8DcXcBH0pLoI6cDeH7A==@lists.infradead.org X-Gm-Message-State: AOJu0Yz/VANIYO4DYiq02jIski6eMvY3PBV/UORT+Na5MLWRUJIHmyFz iTLWZFR7+WHVCcsMZwxQ1W8dSj4PDkQiTeOoAu85Y5Qm+5+13yoTdwqMeMX1D/CXQmM= X-Gm-Gg: Acq92OGqTcXgBl5k3BIuLCkoc5YN49u+3/YICbbMIYV7cjGV8Dry+JJhAog4n1z0ZzW TY6rVQ673dhX42sAKlIlRbnvd2XTj9A2fmcsfsryo7xtKD5+AmLtF1E5oJ7HMBoTRTL3s1oH44g YaFMEmntR9R+XLdOHwXlezBa50pu/mIgPPG7n5AXIatamgFXh+TXmjr4qzOeDDZovrXVvcK/F/e cXXyfXMxL2+Gf3m+GBEfmZgt9uRGmggcO3kTbq6Ds4hHHU2WwCXDznoCnjNK5WtWX+eyHvCmRti XRvJfdnrVWHrTp4Xu5hJf6uso4aKw56wqCfkBuhhg5Zhpkv5VVgzLa4HIeE3X+pu2Jhdj2/15Gs f4IyWZOlqgrZO2d4Dj00N2wUO7YyRKgRYPxXSXiEd5CALx7OdZT/asEPM5C5naSPPHNhGJoDZAA m702mvEp3a+Xt5RZPtOHyM7h0sySB2EbWlIEicWQjzcLlTP5fTYob6tTXQ0WKKx7r/kbEkt8v19 zj91hrje4SWhCRVXfCwtMswp7TQepbCAjWpMI/fmOebQy7ErS7PAQz0esxHvHZnwvzKUQ== X-Received: by 2002:a05:6000:2008:b0:45e:8cdc:4ee8 with SMTP id ffacd0b85a97d-45ea3128ccdmr31052715f8f.6.1779716109692; Mon, 25 May 2026 06:35:09 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d5cb9asm29456456f8f.27.2026.05.25.06.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:35:09 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 15:35:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-4-kees@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260521133326.2465264-4-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260525_063511_857093_73BCF5C4 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On 5/21/26 3:33 PM, Kees Cook wrote: > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > for example: > > @@ > declarer name DEFINE_KERNEL_PARAM_OPS; > identifier OPS; > expression SET, GET; > @@ > - const struct kernel_param_ops OPS = { > - .set = SET, > - .get = GET, > - }; > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); > > Using the macro for initialization means future changes can manipulate > the struct layout and callback prototypes without having to change every > initializer. Nit: For consistency, I suggest also converting the few remaining kernel_param_ops instances that specify only .set and no .get, such as simdisk_param_ops_filename. -- Thanks, Petr