From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CFE5C25B10 for ; Mon, 13 May 2024 12:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0yjd/sb4uh3W+XLlUFtH7oE6+l6oTatynFqvAd22PdU=; b=2ro7xSdd1WEshMo/d0po0Sq2KM rRy6ewbuzgeQv8n2j5USEnRn2Ikwi4ApV75fi+iR3b8hLYROG6oBCrj4iXoW+SHDMGeEvlflPYFrU WDj2dS0hCTw9GV130VYyrHRHQsRVkdj1hjr3eNybpLUs1WBeG2cfS0w72/jD/GWTLPdiCpygo7npb 1DDN7tV9qUzU8SbATQ8asPFFdlBBY1khofqxT4hLX6cSTENcexUNRSeTVG9PApOVXWkPKyAuuTJEY K2ljMU7GKCdx5Dd2jbcGZ2Z34g2ffweU/hTyY5F2ypoDW0Vrq2R5Yy+SjFu2+SoA4EAWZXoY1diPl 4M/JV+NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6VGs-0000000Cuom-45zL; Mon, 13 May 2024 12:59:14 +0000 Received: from frasgout13.his.huawei.com ([14.137.139.46]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6VGp-0000000Cul7-42NW for linux-um@lists.infradead.org; Mon, 13 May 2024 12:59:13 +0000 Received: from mail.maildlp.com (unknown [172.18.186.29]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4VdJyy2qyYz9v7Hm for ; Mon, 13 May 2024 20:42:02 +0800 (CST) Received: from mail02.huawei.com (unknown [7.182.16.47]) by mail.maildlp.com (Postfix) with ESMTP id ED6801404F6 for ; Mon, 13 May 2024 20:59:01 +0800 (CST) Received: from [127.0.0.1] (unknown [10.204.63.22]) by APP1 (Coremail) with SMTP id LxC2BwD36hOKDkJmEmMYCA--.45732S2; Mon, 13 May 2024 13:59:01 +0100 (CET) Message-ID: Subject: Re: [PATCH] arch/x86/um: Disable UBSAN sanitization From: Roberto Sassu To: Johannes Berg , richard@nod.at, anton.ivanov@cambridgegreys.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com Cc: x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, zohar@linux.ibm.com, linux-integrity@vger.kernel.org, Roberto Sassu Date: Mon, 13 May 2024 14:58:46 +0200 In-Reply-To: References: <20240513122754.1282833-1-roberto.sassu@huaweicloud.com> <096121b3e74a7971b5e6a3d77ca8889380de1885.camel@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-CM-TRANSID: LxC2BwD36hOKDkJmEmMYCA--.45732S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr4fXF4xJw48Xry8Zw4DCFg_yoWDGrXEva s2yFW8K39xWF47A39Igr98Janrtr40krn8J34xGFnxtw1kAFWkGa4kArWSvwn5J3W8tF97 u34DtF1rGr1ayjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb7xYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267 AKxVW8JVW8Jr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kIc2xKxwCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04 k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: purev21wro2thvvxqx5xdzvxpfor3voofrz/1tbiAQACBF1jj51CKgAAsD X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_055912_170288_0B907355 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Mon, 2024-05-13 at 14:52 +0200, Johannes Berg wrote: > On Mon, 2024-05-13 at 14:42 +0200, Roberto Sassu wrote: > > On Mon, 2024-05-13 at 14:29 +0200, Johannes Berg wrote: > > > On Mon, 2024-05-13 at 14:27 +0200, Roberto Sassu wrote: > > > > From: Roberto Sassu > > > >=20 > > > > Disable UBSAN sanitization on UML, since UML does not support it. > > > >=20 > > >=20 > > > Luckily, that isn't actually true, nor does it actually do this at al= l. > > > Please fix the commit message. > >=20 > > Thanks, I was actually wondering. I based that statement based on > > ARCH_HAS_UBSAN=3Dn. > >=20 > > Any other solution would be ok. >=20 > Not sure I get it. What you're doing in the patch is perfectly fine and > almost certainly required, but you're definitely not disabling UBSAN on > ARCH=3Dum as you described in the commit message? Ok, I guess the right word is instrumentation (got it from commit d4be85d068b44). And the reason is that the vDSO is executing in user space. Will fix it. Thanks Roberto