From: stian@nixia.no
To: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] trinity commit 23dc478aba breaks syscall "mremap" at a 32 bit user mode linux
Date: Fri, 02 May 2014 08:43:04 +0200 [thread overview]
Message-ID: <dd7386ea80ce1fd3e5a864966b3b5e80@nixia.no> (raw)
In-Reply-To: <5362B53E.5060601@nod.at>
> Yeah, this is because trinity destroys the UML stub code.
> Please test the attached patch, it should fix the root cause of the
> problem.
@@ -124,6 +125,9 @@ static int add_munmap(unsigned long addr, unsigned
long len,
struct host_vm_op *last;
int ret = 0;
+ if ((addr >= STUB_START) && (addr < STUB_END))
+ return -EINVAL;
+
if (hvc->index != 0) {
last = &hvc->ops[hvc->index - 1];
if ((last->type == MUNMAP) &&
I do not know how add_munmap is called, so this is more of a question.
What happens in the use cases where the mmap spans multiple pages, and
the stub is in the middle and other variations?
Should it not check that
a) The start of the MMAP is not within the STUB.
b) The end of the MMAP is within the STUB
c) That the start of the MMAP is not before the STUB and the END is not
after the STUB
Stian Skjelstad
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-05-02 6:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 18:19 [uml-devel] trinity commit 23dc478aba breaks syscall "mremap" at a 32 bit user mode linux Toralf Förster
2014-05-01 9:22 ` Richard Weinberger
2014-05-01 10:29 ` Toralf Förster
2014-05-01 12:33 ` Richard Weinberger
2014-05-01 15:15 ` Toralf Förster
2014-05-01 20:57 ` Richard Weinberger
2014-05-01 21:34 ` Toralf Förster
2014-05-02 7:21 ` Richard Weinberger
2014-05-02 7:46 ` Richard Weinberger
2014-05-02 14:07 ` Toralf Förster
2014-05-02 14:14 ` Richard Weinberger
2014-07-12 17:16 ` Toralf Förster
2014-07-12 18:04 ` Richard Weinberger
2014-05-02 6:43 ` stian [this message]
2014-05-02 9:48 ` Richard Weinberger
2014-07-26 20:01 ` Toralf Förster
2014-07-26 20:07 ` Richard Weinberger
2014-07-26 21:21 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd7386ea80ce1fd3e5a864966b3b5e80@nixia.no \
--to=stian@nixia.no \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox