From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
user-mode-linux-user@lists.sourceforge.net,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: um: Use common error handling code in port_listen_fd()
Date: Mon, 23 Oct 2017 11:01:05 +0200 [thread overview]
Message-ID: <e248c905-eb76-d9bd-6e10-92be8b200590@users.sourceforge.net> (raw)
In-Reply-To: <20171023084800.p26qcpb7iqyqrz4v@mwanda>
> This business of moving the error code to the bottom of the function
> just makes the code less readable.
I got an other software development opinion on this aspect.
Could you become used to the proposed control flow structure
in the affected function?
> I know you never listen to anyone,
My response times might not fir to your preferences.
> but you should stop doing it.
I am going to offer suggestions for change patterns which I find useful.
There are some challenges around change acceptance as usual.
Regards,
Markus
next prev parent reply other threads:[~2017-10-23 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:29 [PATCH] um: Use common error handling code in port_listen_fd() SF Markus Elfring
2017-10-20 18:06 ` Joe Perches
2017-10-20 18:22 ` SF Markus Elfring
2017-10-23 8:48 ` [PATCH] " Dan Carpenter
2017-10-23 9:01 ` SF Markus Elfring [this message]
2017-10-23 9:10 ` Dan Carpenter
2017-10-23 9:17 ` SF Markus Elfring
2017-10-23 10:28 ` [PATCH] " Markus Trippelsdorf
2017-10-23 12:04 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e248c905-eb76-d9bd-6e10-92be8b200590@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dan.carpenter@oracle.com \
--cc=jdike@addtoit.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).