From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: um: Use common error handling code in port_listen_fd() References: <20171023084800.p26qcpb7iqyqrz4v@mwanda> From: SF Markus Elfring Message-ID: Date: Mon, 23 Oct 2017 11:01:05 +0200 MIME-Version: 1.0 In-Reply-To: <20171023084800.p26qcpb7iqyqrz4v@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter , user-mode-linux-devel@lists.sourceforge.net Cc: Jeff Dike , Richard Weinberger , user-mode-linux-user@lists.sourceforge.net, kernel-janitors@vger.kernel.org, LKML List-ID: > This business of moving the error code to the bottom of the function > just makes the code less readable. I got an other software development opinion on this aspect. Could you become used to the proposed control flow structure in the affected function? > I know you never listen to anyone, My response times might not fir to your preferences. > but you should stop doing it. I am going to offer suggestions for change patterns which I find useful. There are some challenges around change acceptance as usual. Regards, Markus