From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knohf-0000y9-8g for linux-um@lists.infradead.org; Fri, 11 Dec 2020 20:07:48 +0000 Message-ID: Subject: Re: [PATCH v4 2/7] um: enable the use of optimized xor routines in UML From: Johannes Berg Date: Fri, 11 Dec 2020 21:07:28 +0100 In-Reply-To: <20201211174559.26010-3-anton.ivanov@cambridgegreys.com> References: <20201211174559.26010-1-anton.ivanov@cambridgegreys.com> <20201211174559.26010-3-anton.ivanov@cambridgegreys.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org Cc: richard@nod.at > +++ b/arch/um/include/asm/fpu/api.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef _ASM_UM_FPU_API_H > +#define _ASM_UM_FPU_API_H > + > +/* Copyright (c) 2020 Cambridge Greys Ltd > + * Copyright (c) 2020 Red Hat Inc. > + * A set of "dummy" defines to allow the direct inclusion > + * of x86 optimized copy, xor, etc routines into the > + * UML code tree. */ > + > +#define kernel_fpu_begin() (void)0 > +#define kernel_fpu_end() (void)0 I think I would prefer those to be static inlines, but YMMV. johannes > diff --git a/arch/um/include/asm/xor-x86.h b/arch/um/include/asm/xor-x86.h > new file mode 120000 > index 000000000000..beff7de6890d > --- /dev/null > +++ b/arch/um/include/asm/xor-x86.h > @@ -0,0 +1 @@ > +../../../x86/include/asm/xor.h Do these really need to be symlinks? Last I looked, it seemed that arch/x86/include/asm/ is actually in the include path? > --- a/arch/um/include/asm/xor.h > +++ b/arch/um/include/asm/xor.h > @@ -1,7 +1,22 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#include > +#ifndef _ASM_UM_XOR_H > +#define _ASM_UM_XOR_H > + > +#ifdef CONFIG_64BIT > +#undef CONFIG_X86_32 > +#else > +#define CONFIG_X86_32 1 > +#endif > + > +#include > +#include and thus this could just be #include_next without the symlink? > diff --git a/arch/um/include/asm/xor_32.h b/arch/um/include/asm/xor_32.h > new file mode 120000 > index 000000000000..8a0894e996d7 > --- /dev/null > +++ b/arch/um/include/asm/xor_32.h And the others don't exist in um anyway, so probably aren't needed? But maybe I'm confused about the include path, I didn't double-check now. johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um