From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Berg <benjamin@sipsolutions.net>, linux-um@lists.infradead.org
Subject: Re: [PATCH v3 10/12] um: remove force_flush_all from fork_handler
Date: Wed, 03 Jul 2024 12:10:11 +0200 [thread overview]
Message-ID: <efda3d88c20ff9044cdb7e84066d307adcfbeb11.camel@sipsolutions.net> (raw)
In-Reply-To: <f78b8fc811194acb87c091b9064fb7446894f5cf.camel@sipsolutions.net>
On Wed, 2024-07-03 at 12:08 +0200, Benjamin Berg wrote:
> On Wed, 2024-07-03 at 11:45 +0200, Johannes Berg wrote:
> > On Fri, 2024-05-24 at 23:37 +0200, benjamin@sipsolutions.net wrote:
> > > From: Benjamin Berg <benjamin.berg@intel.com>
> > >
> > > There should be no need for this.
> >
> > "should" ;-)
>
> Hmm, I would have expected the previous patch is what breaks it.
Ouch, you're right, I replied to the wrong patch - bisected to the
previous one indeed.
> > This breaks things if glibc enables rseq. That might even be already
> > broken in the sense that it might corrupt memory that's put at the same
> > place the rseq was installed? But it at least it appears to still work
> > without this patch...
>
> Then it would make sense to me as the previous force_flush_all would
> have only unmapped up to TASK_SIZE. While this now uses STUB_START
> which clears more memory as TASK_SIZE has some alignment.
Right.
johannes
next prev parent reply other threads:[~2024-07-03 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 21:37 [PATCH v3 00/12] Rework stub syscall and page table handling benjamin
2024-05-24 21:37 ` [PATCH v3 01/12] um: Remove stub-data.h include from common-offsets.h benjamin
2024-05-24 21:37 ` [PATCH v3 02/12] um: Create signal stack memory assignment in stub_data benjamin
2024-05-24 21:37 ` [PATCH v3 03/12] um: Add generic stub_syscall6 function benjamin
2024-05-24 21:37 ` [PATCH v3 04/12] um: Rework syscall handling benjamin
2024-05-24 21:37 ` [PATCH v3 05/12] um: compress memory related stub syscalls while adding them benjamin
2024-05-24 21:37 ` [PATCH v3 06/12] um: remove LDT support benjamin
2024-05-24 21:37 ` [PATCH v3 07/12] um: remove copy_context_skas0 benjamin
2024-05-24 21:37 ` [PATCH v3 08/12] um: Delay flushing syscalls until the thread is restarted benjamin
2024-05-24 21:37 ` [PATCH v3 09/12] um: Do not flush MM in flush_thread benjamin
2024-05-24 21:37 ` [PATCH v3 10/12] um: remove force_flush_all from fork_handler benjamin
2024-07-03 9:45 ` Johannes Berg
2024-07-03 10:08 ` Benjamin Berg
2024-07-03 10:10 ` Johannes Berg [this message]
2024-07-03 13:00 ` Johannes Berg
2024-05-24 21:37 ` [PATCH v3 11/12] um: simplify and consolidate TLB updates benjamin
2024-05-24 21:37 ` [PATCH v3 12/12] um: refactor TLB update handling benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efda3d88c20ff9044cdb7e84066d307adcfbeb11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox