linux-um archives
 help / color / mirror / Atom feed
From: "Roman Yepishev" <roman.yepishev@gmail.com>
To: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] UML crashes when built with _FORTIFY_SOURCE
Date: Sat, 25 Oct 2008 02:08:31 +0300	[thread overview]
Message-ID: <f39be10d0810241608i590d13f5p429c02558a1c26cf@mail.gmail.com> (raw)

Hello,

When UML kernel is built with _FORTIFY_SOURCE defined, then all
arguments for snprintf, printf etc. are checked by glibc.

mconsole_init defines file[256] which is used later to construct the
socket path.
file is then passed to os_create_unix_socket which in turn uses
sockaddr_un to describe the socket.
The problem happens when snprintf tries to fit file into sun_path
which is only 108 bytes long. The checks fail and kernel abort()s.

Temporary solution is to fix file declaration to be 108 or less bytes
but checks should be introduced when socket path is constructed.

The complete history of bug is here:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/284631

-- 
Regards,
Roman Yepishev

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

             reply	other threads:[~2008-10-24 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 23:08 Roman Yepishev [this message]
2008-10-31 19:14 ` [uml-devel] UML crashes when built with _FORTIFY_SOURCE Jeff Dike
2008-11-03 21:35   ` Roman Yepishev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f39be10d0810241608i590d13f5p429c02558a1c26cf@mail.gmail.com \
    --to=roman.yepishev@gmail.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox