From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-um-bounces+geert=linux-m68k.org@lists.infradead.org>
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634])
 by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux))
 id 1lLyMy-00HBAk-Vh
 for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:19:38 +0000
Received: by mail-pl1-x634.google.com with SMTP id n17so12614510plc.7
 for <linux-um@lists.infradead.org>; Mon, 15 Mar 2021 18:19:36 -0700 (PDT)
Date: Tue, 16 Mar 2021 10:19:33 +0900
Message-ID: <m235wvc2u2.wl-thehajime@gmail.com>
From: Hajime Tazaki<thehajime@gmail.com>
Subject: Re: [RFC v8 11/20] um: lkl: basic console support
In-Reply-To: <1aebaecdb4c5b3e62f5a89618b9d13f237d6b3c1.camel@sipsolutions.net>
References: <cover.1611103406.git.thehajime@gmail.com>
 <5ec3a7157f7d96943b5701f8d57e102181cd56d2.1611103406.git.thehajime@gmail.com>
 <1aebaecdb4c5b3e62f5a89618b9d13f237d6b3c1.camel@sipsolutions.net>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
List-Id: <linux-um.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-um/>
List-Post: <mailto:linux-um@lists.infradead.org>
List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-um" <linux-um-bounces@lists.infradead.org>
Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org
To: johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com


On Mon, 15 Mar 2021 05:42:52 +0900,
Johannes Berg wrote:
> 
> 
> > 
> > -obj-y := stdio_console.o fd.o chan_kern.o chan_user.o line.o
> > +ifndef CONFIG_UMMODE_LIB
> > +obj-y := stdio_console.o
> > +else
> > +obj-y :=
> > +endif
> > +obj-y += fd.o chan_kern.o chan_user.o line.o
> 
> Might nicer to do via Kconfig, such as
> 
> config STDIO_CONSOLE
> 	def_bool y
> 	depends on !UMMODE_LIB
> 
> and then
> 
> obj-$(CONFIG_STDIO_CONSOLE) += stdio_console.o
> 
> here. Similar to CONFIG_STDDER_CONSOLE, after all.

Agree.  I'll fix them.

> > +/**
> > + * lkl_print - optional operation that receives console messages
> 
> How is it optional? I don't see you having a __weak definition?

Optional is misleading...  I will fix the comment.

-- Hajime

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um