From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLyMS-00HB7C-U5 for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:19:07 +0000 Received: by mail-pf1-x42d.google.com with SMTP id e26so7711745pfd.9 for ; Mon, 15 Mar 2021 18:19:04 -0700 (PDT) Date: Tue, 16 Mar 2021 10:19:02 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v8 19/20] um: lkl: add block device support of UML In-Reply-To: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> References: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com On Mon, 15 Mar 2021 05:37:40 +0900, Johannes Berg wrote: > = > On Wed, 2021-01-20 at 11:27 +0900, Hajime Tazaki wrote: > > = > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > index 24c6596260de..5fb6a852d058 100644 > > --- a/arch/um/Kconfig > > +++ b/arch/um/Kconfig > > @@ -29,6 +29,10 @@ config UMMODE_LIB > > =A0 select UACCESS_MEMCPY > > =A0 select ARCH_THREAD_STACK_ALLOCATOR > > =A0 select ARCH_HAS_SYSCALL_WRAPPER > > + select VFAT_FS > > + select NLS_CODEPAGE_437 > > + select NLS_ISO8859_1 > > + select BTRFS_FS > = > That doesn't really seem to make sense - the sample might need it, but > generally LKL doesn't/shouldn't? I'm trying to understand your comment; Do you mean that enabling those options in Kconfig doesn't make sense ? and if you mean the sample as sample code, is the added test case (e.g., tools/testing/selftests/um/disk.c, which is included in the same patch) for this purpose ? -- HAjime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um