From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-um-bounces+geert=linux-m68k.org@lists.infradead.org>
Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d])
 by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux))
 id 1lLyLU-00HB2e-Rv
 for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:18:06 +0000
Received: by mail-pf1-x42d.google.com with SMTP id y67so7726559pfb.2
 for <linux-um@lists.infradead.org>; Mon, 15 Mar 2021 18:18:01 -0700 (PDT)
Date: Tue, 16 Mar 2021 10:17:59 +0900
Message-ID: <m2a6r3c2wo.wl-thehajime@gmail.com>
From: Hajime Tazaki<thehajime@gmail.com>
Subject: Re: [RFC v8 07/20] um: lkl: host interface
In-Reply-To: <e18da756e9efcae8489c658907b62d68f0969da0.camel@sipsolutions.net>
References: <cover.1611103406.git.thehajime@gmail.com>
 <f149135f1943eb81998d54c923c10ebffb0b4518.1611103406.git.thehajime@gmail.com>
 <e18da756e9efcae8489c658907b62d68f0969da0.camel@sipsolutions.net>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
List-Id: <linux-um.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-um/>
List-Post: <mailto:linux-um@lists.infradead.org>
List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-um" <linux-um-bounces@lists.infradead.org>
Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org
To: johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com


On Mon, 15 Mar 2021 01:50:27 +0900,
Johannes Berg wrote:
> 
> 
> > +/**
> > + * struct lkl_host_operations - host operations used by the Linux kernel
> > + *
> > + * These operations must be provided by a host library or by the application
> > + * itself.
> > + *
> > + */
> > +struct lkl_host_operations {
> > +};
> 
> IIRC, in previous reviews we discussed this and you said you'd look at
> just making those extern functions, instead of function pointers, since
> realistically there's no use in being able to switch these at runtime.
> What happened to that? Any particular reason not to?

Yes, I followed your suggestion that we just use functions instead of
function pointers ([17/20]).

Though we won't use pointers, we still need this structure to inform
userspace side (of LKL) to kernel. [19/20], block device
implementation uses this.

-- Hajime


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um