From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2kW7-0006zk-Og for linux-um@lists.infradead.org; Fri, 22 Jan 2021 00:41:36 +0000 Received: by mail-pj1-x102f.google.com with SMTP id g15so2772416pjd.2 for ; Thu, 21 Jan 2021 16:41:33 -0800 (PST) Date: Fri, 22 Jan 2021 09:41:19 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [PATCH] um: ubd: Fix crash from option parsing In-Reply-To: <20210119181945.2071053-1-paullawrence@google.com> References: <20210119181945.2071053-1-paullawrence@google.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: paullawrence@google.com Cc: richard@nod.at, jdike@addtoit.com, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, krisman@collabora.com, chris.obbard@collabora.com, anton.ivanov@cambridgegreys.com Hello, On Wed, 20 Jan 2021 03:19:45 +0900, Paul Lawrence wrote: > > Below patch will cause NULL ptr dereferences if the optional filenames > are not present. > > Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline) > Signed-off-by: Paul Lawrence This was addressed/fixed by the below patch, though that one doesn't the first "file" variable check. http://lists.infradead.org/pipermail/linux-um/2020-December/000983.html There was another attempt to fix (with the same diff), btw. http://lists.infradead.org/pipermail/linux-um/2021-January/000998.html It seems that the patch is already queued but not upstreamed yet. -- Hajime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um