From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 09 Oct 2020 15:24:32 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v7 20/21] um: host: add test programs In-Reply-To: <11f40c1a85a118d8207a6f05fc574164a01af3a9.camel@sipsolutions.net> References: <363dceeefe1c468adca17cec0b7ba4fad7c76ef3.1601960644.git.thehajime@gmail.com> <11f40c1a85a118d8207a6f05fc574164a01af3a9.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, retrage01@gmail.com, linux-arch@vger.kernel.org List-ID: On Thu, 08 Oct 2020 04:23:51 +0900, Johannes Berg wrote: > > On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > > > +LKL_TEST_CALL(getpid, lkl_sys_getpid, 1) > > Could that be unified with KUNIT somehow? > > > +++ b/tools/um/tests/run.py > > @@ -0,0 +1,172 @@ > > +#!/usr/bin/env python > > +# SPDX-License-Identifier: GPL-2.0 > > +# > > +# This program is free software; you can redistribute it and/or modify > > +# it under the terms of the GNU General Public License as published by > > +# the Free Software Foundation; version 2 of the License > > +# > > +# Author: Octavian Purdila > > +# > > + > > +from __future__ import print_function > > + > > +import argparse > > +import os > > +import subprocess > > +import sys > > +import tap13 > > ok, I see now, you're doing something with TAP (test anything > protocol)... > > Hmm. I must say I'm not a fan of adding a whole testing framework to the > kernel like that, even if it's pretty simple. > > > +import xml.etree.ElementTree as ET > > + > > +from junit_xml import TestSuite, TestCase > > yuck > > Let's see if you can use KUNIT instead. Anything beyond that doesn't > really need to live in the kernel, IMHO. I see the point. I'm gonna play with kunit to check if it's doable. Thanks, -- Hajime