From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMgJw-0049SS-SI for linux-um@lists.infradead.org; Thu, 18 Mar 2021 00:15:26 +0000 Received: by mail-pf1-x432.google.com with SMTP id l3so2253969pfc.7 for ; Wed, 17 Mar 2021 17:15:22 -0700 (PDT) Date: Thu, 18 Mar 2021 09:15:25 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v8 19/20] um: lkl: add block device support of UML In-Reply-To: <3d3e446409d00dfbe62320832799d0a3b34b2b9c.camel@sipsolutions.net> References: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> <56af0e44c846f4b079256ec997c56119964be402.camel@sipsolutions.net> <3d3e446409d00dfbe62320832799d0a3b34b2b9c.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: johannes@sipsolutions.net Cc: tavi.purdila@gmail.com, linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com On Wed, 17 Mar 2021 23:28:10 +0900, Johannes Berg wrote: > > On Wed, 2021-03-17 at 16:19 +0200, Octavian Purdila wrote: > > > I can understand that your sample code wants btrfs just to show what it > > > can do, but IMHO it doesn't make sense to *always* enable it. > > Btw, what I said there also didn't distinguish between "always enable > it" and "always force it enabled". > > Right now this patch did the latter, but the former might sort of make > sense, but would take the form of a defconfig rather than a Kconfig code > change. Thanks, I understand the situation. I agree that using defconfig should be good in this case. Will fix this. > > I agree. I think these can stay in defconfigs but here is where a > > library introduces complications which I don't know how is best to > > handle. Should we have the defconfig in arch/um or should we have it > > in tools/testing/selftests/um? Or perhaps both places, one being a > > generic config that would be used by most applications and one > > customized? > > Yeah, that's a question - and in that sense LKL will never be a general- > purpose "library" since then you'd have to basically build it with > "allyesconfig" instead of other things. > > Maybe just put a note there with the tools, and maybe a defconfig, and > then have some kind of detection at example/tool build or even runtime > that the necessary options are selected? preparing multiple defconfigs (e.g., tiny, normal, allyes) would be one option for build-time selection. Other possibilities (rather radical) could be to prepare multiple sub-libraries (liblinux-core.so liblinux-fs-ext4.so, liblinux-net.so, etc) so that users can pick only necessary codes when it's build (or open during runtime). This needs to handle dependencies as kernel modules do, thus it's more complicated once we have this ? -- Hajime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um