From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-um-bounces+geert=linux-m68k.org@lists.infradead.org>
Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e])
 by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux))
 id 1lMgGh-0049KW-Po
 for linux-um@lists.infradead.org; Thu, 18 Mar 2021 00:12:05 +0000
Received: by mail-pl1-x62e.google.com with SMTP id v8so378827plz.10
 for <linux-um@lists.infradead.org>; Wed, 17 Mar 2021 17:12:02 -0700 (PDT)
Date: Thu, 18 Mar 2021 09:12:05 +0900
Message-ID: <m2zgz19v6y.wl-thehajime@gmail.com>
From: Hajime Tazaki<thehajime@gmail.com>
Subject: Re: [RFC v8 08/20] um: lkl: memory handling
In-Reply-To: <87933c0d6c07745b20f6724721e3bf2da8f67f72.camel@sipsolutions.net>
References: <cover.1611103406.git.thehajime@gmail.com>
 <19d4990f2ef77ad595248183071da5e43149931c.1611103406.git.thehajime@gmail.com>
 <03c74a353c87994b61450ba8086f1ccda40b2ea8.camel@sipsolutions.net>
 <m28s6nc2w1.wl-thehajime@gmail.com>
 <87933c0d6c07745b20f6724721e3bf2da8f67f72.camel@sipsolutions.net>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
List-Id: <linux-um.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-um/>
List-Post: <mailto:linux-um@lists.infradead.org>
List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>,
 <mailto:linux-um-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-um" <linux-um-bounces@lists.infradead.org>
Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org
To: johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com


Hello,

On Wed, 17 Mar 2021 06:31:03 +0900,
Johannes Berg wrote:
> 
> On Tue, 2021-03-16 at 10:18 +0900, Hajime Tazaki wrote:
> > 
> > > > +void *uml_kmalloc(int size, int flags)
> > > > +{
> > > > +	return kmalloc(size, flags);
> > > > +}
> > > 
> > > That could probably still be shared?
> > 
> > This function is a stub of arch/um/kernel/mem.c, which LKL doesn't
> > use for the build.  Thus we defined here.
> > 
> > Or are you suggesting to not stubbing this function, but extracting
> > the function from mem.c ?
> 
> Yes, that's kind of what I was thinking.

Okay, I'll look for a fix with this approach.

> OTOH, I guess it's in os-Linux today?

sorry, I didn't get this line.  uml_kmalloc() is in kernel/mem.c but
what is in os-Linux ?

Thanks,
-- Hajime

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um