From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Richard Weinberger" <richard@nod.at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Josef Bacik" <josef@toxicpanda.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Dongsheng Yang" <dongsheng.yang@easystack.cn>,
"Roger Pau Monné" <roger.pau@citrix.com>,
linux-um@lists.infradead.org, linux-block@vger.kernel.org,
nbd@other.debian.org, ceph-devel@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
"Bart Van Assche" <bvanassche@acm.org>,
"Damien Le Moal" <dlemoal@kernel.org>
Subject: Re: [PATCH 09/14] sd: factor out a sd_discard_mode helper
Date: Thu, 13 Jun 2024 21:43:58 -0400 [thread overview]
Message-ID: <yq1msnos3hl.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240531074837.1648501-10-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 May 2024 09:48:04 +0200")
Christoph,
> Split the logic to pick the right discard mode into a little helper
> to prepare for further changes.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-06-14 1:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 7:47 convert the SCSI ULDs to the atomic queue limits API v2 Christoph Hellwig
2024-05-31 7:47 ` [PATCH 01/14] ubd: refactor the interrupt handler Christoph Hellwig
2024-06-14 1:35 ` Martin K. Petersen
2024-06-14 7:28 ` Anton Ivanov
2024-05-31 7:47 ` [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling Christoph Hellwig
2024-06-14 1:36 ` Martin K. Petersen
2024-06-14 7:29 ` Anton Ivanov
2024-05-31 7:47 ` [PATCH 03/14] rbd: increase io_opt again Christoph Hellwig
2024-05-31 9:08 ` Ilya Dryomov
2024-06-14 1:36 ` Martin K. Petersen
2024-05-31 7:47 ` [PATCH 04/14] block: take io_opt and io_min into account for max_sectors Christoph Hellwig
2024-05-31 9:11 ` Ilya Dryomov
2024-06-14 1:40 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 05/14] sd: simplify the ZBC case in provisioning_mode_store Christoph Hellwig
2024-06-14 1:41 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 06/14] sd: add a sd_disable_discard helper Christoph Hellwig
2024-06-14 1:41 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 07/14] sd: add a sd_disable_write_same helper Christoph Hellwig
2024-06-14 1:42 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 08/14] sd: simplify the disable case in sd_config_discard Christoph Hellwig
2024-06-14 1:43 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 09/14] sd: factor out a sd_discard_mode helper Christoph Hellwig
2024-06-14 1:43 ` Martin K. Petersen [this message]
2024-05-31 7:48 ` [PATCH 10/14] sd: cleanup zoned queue limits initialization Christoph Hellwig
2024-06-14 1:44 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 11/14] sd: convert to the atomic queue limits API Christoph Hellwig
2024-05-31 11:34 ` John Garry
2024-06-14 1:47 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 12/14] sr: " Christoph Hellwig
2024-06-14 1:48 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 13/14] block: remove unused " Christoph Hellwig
2024-05-31 11:12 ` John Garry
[not found] ` <CGME20240531140203epcas5p1fed913b6729b684e0916dfd62787be13@epcas5p1.samsung.com>
2024-05-31 13:55 ` Nitesh Shetty
2024-06-14 1:48 ` Martin K. Petersen
2024-05-31 7:48 ` [PATCH 14/14] block: add special APIs for run-time disabling of discard and friends Christoph Hellwig
[not found] ` <CGME20240531110559epcas5p1f41d7d904ed46260837c38a57fa32d86@epcas5p1.samsung.com>
2024-05-31 10:58 ` Nitesh Shetty
2024-05-31 11:12 ` John Garry
2024-06-14 1:49 ` Martin K. Petersen
2024-05-31 11:29 ` convert the SCSI ULDs to the atomic queue limits API v2 John Garry
2024-05-31 12:07 ` Martin K. Petersen
2024-05-31 12:23 ` Christoph Hellwig
2024-06-14 16:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1msnos3hl.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=dongsheng.yang@easystack.cn \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=nbd@other.debian.org \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).