From: Sven Schnelle <svens@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
christophe.leroy@csgroup.eu, jeffxu@google.com,
Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org,
npiggin@gmail.com, oliver.sang@intel.com,
pedro.falcato@gmail.com, linux-um@lists.infradead.org,
linux-s390@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping
Date: Tue, 03 Sep 2024 08:27:19 +0200 [thread overview]
Message-ID: <yt9dr0a1uu9k.fsf@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wjD0XLhkzou89J-TK=L6B88pFoNYxN1uTWRQB3U5Czywg@mail.gmail.com> (Linus Torvalds's message of "Mon, 2 Sep 2024 14:02:56 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, 2 Sept 2024 at 13:49, Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> uprobe_clear_state() is a pretty simple low-level thing. Side-effects
>> seem unlikely?
>
> I think uprobe_clear_state() should be removed from fork.c entirely,
> made 'static', and then we'd have
>
> area->xol_mapping.close = uprobe_clear_state;
>
> in __create_xol_area() instead (ok, the arguments change, instead of
> looking up "mm->uprobes_state.xol_area", it would get it as the vma
> argument)
>
> That's how it should always have been, except we didn't have a close() function.
>
> Hmm?
Indeed, that's much better. I'll prepare a patch.
Thanks!
prev parent reply other threads:[~2024-09-03 6:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240812082605.743814-1-mpe@ellerman.id.au>
2024-08-19 18:52 ` [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping Nathan Chancellor
2024-08-19 19:29 ` Linus Torvalds
2024-08-19 19:51 ` Nathan Chancellor
2024-08-19 20:15 ` Linus Torvalds
2024-08-19 20:16 ` Linus Torvalds
2024-08-20 1:05 ` Andrew Morton
2024-08-20 1:11 ` Linus Torvalds
2024-08-20 6:26 ` Michael Ellerman
2024-08-20 15:31 ` Linus Torvalds
2024-08-20 21:31 ` Rob Landley
2024-08-20 21:31 ` Linus Torvalds
2024-08-20 22:10 ` Rob Landley
2024-08-20 23:14 ` Linus Torvalds
2024-08-21 1:18 ` Andrew Morton
2024-09-02 19:06 ` Sven Schnelle
2024-09-02 20:49 ` Andrew Morton
2024-09-02 21:02 ` Linus Torvalds
2024-09-03 6:27 ` Sven Schnelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dr0a1uu9k.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jeffxu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=npiggin@gmail.com \
--cc=oliver.sang@intel.com \
--cc=pedro.falcato@gmail.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).