From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: KASAN: slab-out-of-bounds Read in string (2) Date: Wed, 24 Oct 2018 06:40:35 -0400 Message-ID: <09f6038b7642f425eba162ea2239552e12da2045.camel@kernel.org> References: <0000000000003852440576ef80b2@google.com> <20181024090959.s5y3azpsmtswjyn5@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Amir Goldstein , Dan Carpenter , Bruce Fields Cc: Dmitry Vyukov , syzbot+376cea2b0ef340db3dd4@syzkaller.appspotmail.com, Miklos Szeredi , overlayfs , linux-kernel , Petr Mladek , "Steven Rostedt (VMware)" , Sergey Senozhatsky , syzkaller-bugs@googlegroups.com, Jan Harkes , Mark Fasheh List-Id: linux-unionfs@vger.kernel.org On Wed, 2018-10-24 at 12:35 +0300, Amir Goldstein wrote: > > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c > > > index d35cd6be0675..93fb7cf0b92b 100644 > > > --- a/fs/lockd/host.c > > > +++ b/fs/lockd/host.c > > > @@ -341,7 +341,7 @@ struct nlm_host *nlmsvc_lookup_host(const struct > > > svc_rqst *rqstp, > > > }; > > > struct lockd_net *ln = net_generic(net, lockd_net_id); > > > > > > - dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__, > > > + dprintk("lockd: %s(host='%.*s', vers=%u, proto=%s)\n", __func__, > > > (int)hostname_len, hostname, rqstp->rq_vers, > > > (rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp")); > > > > > > > Why wasn't this one applied? It looks correct to me. The rest seem to > > have been fixed already. > > > > I did not send this patch to Jeff. > Jeff was CC'ed on the patch I sent to Miklos > and Miklos decided to only take the overlayfs bits: > https://marc.info/?l=linux-unionfs&m=153847248625015&w=2 > > So I guess it has fallen between the cracks. > Feel free to send a patch to Jeff. > > Thanks, > Amir. Actually, this should probably go to Bruce, as he mostly takes care of lockd. Patch looks correct though. Thanks, -- Jeff Layton