Re: [PATCH v2 06/25] capability: provide helpers for converting between xattrs and vfs_caps

Christian Brauner
2024-02-23T08:08:14Z

On Thu, Feb 22, 2024 at 09:38:04AM -0600, Seth Forshee (DigitalOcean) wrote:
> On Thu, Feb 22, 2024 at 04:20:08PM +0100, Christian Brauner wrote:
> > > + if ((magic_etc & VFS_CAP_REVISION_MASK) != VFS_CAP_REVISION_1) {
> > > + vfs_caps->permitted.val += (u64)le32_to_cpu(caps->data[1].permitted) << 32;
> > > + vfs_caps->inheritable.val += (u64)le32_to_cpu(caps->data[1].inheritable) << 32;
> >
> > That + makes this even more difficult to read. This should be rewritten.
>
> Do you meant that you would prefer |= to +=, or do you have something

Yes.