Re: [PATCH v2 01/25] mnt_idmapping: split out core vfs[ug]id_t definitions into vfsid.h

Christian Brauner
2024-02-22T14:09:55Z

On Wed, Feb 21, 2024 at 03:24:32PM -0600, Seth Forshee (DigitalOcean) wrote:
> The rootid member of cpu_vfs_cap_data is a kuid_t, but it should be a
> vfsuid_t as the id stored there is mapped into the mount idmapping. It's
> currently impossible to use vfsuid_t within cred.h though as it is
> defined in mnt_idmapping.h, which uses definitions from cred.h.
>
> Split out the core vfsid type definitions into a separate file which can
> be included from cred.h.
>
> Signed-off-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
> ---

Looks good,
Reviewed-by: Christian Brauner <brauner@kernel.org>