public inbox for linux-unionfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Lv Fei(吕飞)" <feilv@asrmicro.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "miklos@szeredi.hu" <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: 答复: overlayfs issue: dir permission lost during overlayfs copy-up
Date: Wed, 17 Jul 2024 12:41:00 +0000	[thread overview]
Message-ID: <1393d3786fc54f05a661eb41394dc982@exch01.asrmicro.com> (raw)
In-Reply-To: <CAOQ4uxgPSrjA20EAHeoGxjtE7odO6t1V1O4abOwUW8J2rTDBOw@mail.gmail.com>


> -----邮件原件-----
> 发件人: Amir Goldstein [mailto:amir73il@gmail.com] 
> 发送时间: 2024年7月16日 16:19
> 收件人: Lv Fei(吕飞) <feilv@asrmicro.com>
> 抄送: miklos@szeredi.hu; overlayfs <linux-unionfs@vger.kernel.org>
> 主题: Re: overlayfs issue: dir permission lost during overlayfs copy-up
> 
> > And for version 5.4.276, I need to add fsync at the end of ovl_copy_up_inode (correspond to latest function ovl_copy_up_metadata), right?
> >
> 
> Sounds right, but I do not have time to examine out-of-tree backport effort.
> First, you need to provide a working and tested patch for upstream.
> If that gets accepted, we can discuss backporting efforts.
> But the general idea is this:
> ovl_do_rename() serves as the "atomic" copy up operation everything that happens before that will not be observed after crash if rename did not happen.
> 
> The problem is that inode metadata changes that happened before rename are NOT guaranteed by POSIX to be observed after crash even by rename is observe unless fsync() is called on the source inode before rename.
> 
> Thanks,
> Amir.

OK, I finished a patch based on 6.10 today, will post for review.

Thanks,
Fei

      reply	other threads:[~2024-07-17 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a2391c78f3974c5d92aa53574bde4eca@exch01.asrmicro.com>
2024-07-12  9:40 ` overlayfs issue: dir permission lost during overlayfs copy-up Amir Goldstein
2024-07-15  6:06   ` 答复: " Lv Fei(吕飞)
2024-07-15 10:07     ` Amir Goldstein
2024-07-16  2:51       ` 答复: " Lv Fei(吕飞)
2024-07-16  8:19         ` Amir Goldstein
2024-07-17 12:41           ` Lv Fei(吕飞) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393d3786fc54f05a661eb41394dc982@exch01.asrmicro.com \
    --to=feilv@asrmicro.com \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox