linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: miklos@szeredi.hu, sds@tycho.nsa.gov, pmoore@redhat.com,
	casey@schaufler-ca.com, linux-kernel@vger.kernel.org,
	linux-unionfs@vger.kernel.org,
	linux-security-module@vger.kernel.org
Cc: dwalsh@redhat.com, dhowells@redhat.com, viro@ZenIV.linux.org.uk,
	vgoyal@redhat.com, linux-fsdevel@vger.kernel.org
Subject: [PATCH 5/7] selinux: Pass security pointer to determine_inode_label()
Date: Fri,  8 Jul 2016 12:19:40 -0400	[thread overview]
Message-ID: <1467994782-26474-6-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1467994782-26474-1-git-send-email-vgoyal@redhat.com>

Right now selinux_determine_inode_label() works on security pointer of
current task. Soon I need this to work on a security pointer retrieved
from a set of creds. So start passing in a pointer and caller can decide
where to fetch security pointer from.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 security/selinux/hooks.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 4fda548..ae11fd9 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1785,13 +1785,13 @@ out:
 /*
  * Determine the label for an inode that might be unioned.
  */
-static int selinux_determine_inode_label(struct inode *dir,
-					 const struct qstr *name,
-					 u16 tclass,
-					 u32 *_new_isid)
+static int
+selinux_determine_inode_label(const struct task_security_struct *tsec,
+				 struct inode *dir,
+				 const struct qstr *name, u16 tclass,
+				 u32 *_new_isid)
 {
 	const struct superblock_security_struct *sbsec = dir->i_sb->s_security;
-	const struct task_security_struct *tsec = current_security();
 
 	if ((sbsec->flags & SE_SBINITIALIZED) &&
 	    (sbsec->behavior == SECURITY_FS_USE_MNTPOINT)) {
@@ -1834,8 +1834,8 @@ static int may_create(struct inode *dir,
 	if (rc)
 		return rc;
 
-	rc = selinux_determine_inode_label(dir, &dentry->d_name, tclass,
-					   &newsid);
+	rc = selinux_determine_inode_label(current_security(), dir,
+					   &dentry->d_name, tclass, &newsid);
 	if (rc)
 		return rc;
 
@@ -2815,7 +2815,8 @@ static int selinux_dentry_init_security(struct dentry *dentry, int mode,
 	u32 newsid;
 	int rc;
 
-	rc = selinux_determine_inode_label(d_inode(dentry->d_parent), name,
+	rc = selinux_determine_inode_label(current_security(),
+					   d_inode(dentry->d_parent), name,
 					   inode_mode_to_security_class(mode),
 					   &newsid);
 	if (rc)
@@ -2840,7 +2841,7 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir,
 	sid = tsec->sid;
 	newsid = tsec->create_sid;
 
-	rc = selinux_determine_inode_label(
+	rc = selinux_determine_inode_label(current_security(),
 		dir, qstr,
 		inode_mode_to_security_class(inode->i_mode),
 		&newsid);
-- 
2.7.4

  parent reply	other threads:[~2016-07-08 16:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 16:19 [RFC PATCH 0/7][V2] Overlayfs SELinux Support Vivek Goyal
2016-07-08 16:19 ` [PATCH 1/7] security, overlayfs: provide copy up security hook for unioned files Vivek Goyal
2016-07-11 15:24   ` Stephen Smalley
2016-07-11 16:54     ` Vivek Goyal
2016-07-08 16:19 ` [PATCH 2/7] selinux: Implementation for inode_copy_up() hook Vivek Goyal
2016-07-08 16:19 ` [PATCH 3/7] security,overlayfs: Provide security hook for copy up of xattrs for overlay file Vivek Goyal
2016-07-08 17:41   ` kbuild test robot
2016-07-11 13:40     ` Vivek Goyal
2016-07-11 13:50       ` [kbuild-all] [PATCH 3/7] security, overlayfs: " Fengguang Wu
2016-07-12  0:02       ` [PATCH 3/7] security,overlayfs: " Stephen Rothwell
2016-07-11 15:31   ` Stephen Smalley
2016-07-11 16:56     ` Vivek Goyal
2016-07-11 17:02     ` Vivek Goyal
2016-07-08 16:19 ` [PATCH 4/7] selinux: Implementation for inode_copy_up_xattr() hook Vivek Goyal
2016-07-08 16:19 ` Vivek Goyal [this message]
2016-07-08 16:19 ` [PATCH 6/7] security, overlayfs: Provide hook to correctly label newly created files Vivek Goyal
2016-07-08 16:19 ` [PATCH 7/7] selinux: Implement dentry_create_files_as() hook Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467994782-26474-6-git-send-email-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=dhowells@redhat.com \
    --cc=dwalsh@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=pmoore@redhat.com \
    --cc=sds@tycho.nsa.gov \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).