From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Subject: [PATCH v5 01/17] xattr: Remove unnecessary NULL attribute name check Date: Wed, 28 Sep 2016 16:57:47 +0200 Message-ID: <1475074683-26971-2-git-send-email-agruenba@redhat.com> References: <1475074683-26971-1-git-send-email-agruenba@redhat.com> Return-path: In-Reply-To: <1475074683-26971-1-git-send-email-agruenba@redhat.com> Sender: ecryptfs-owner@vger.kernel.org To: Alexander Viro Cc: Andreas Gruenbacher , linux-fsdevel@vger.kernel.org, Tyler Hicks , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Serge Hallyn , Dmitry Kasatkin , linux-ima-devel@lists.sourceforge.net, Paul Moore , Stephen Smalley , Eric Paris , Casey Schaufler , Oleg Drokin , Andreas Dilger List-Id: linux-unionfs@vger.kernel.org When NULL is passed to one of the xattr system calls as the attribute name, copying that name from user space already fails with -EFAULT; xattr_resolve_name is never called with a NULL attribute name. Signed-off-by: Andreas Gruenbacher --- fs/xattr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/xattr.c b/fs/xattr.c index c243905..1f72c92 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -675,9 +675,6 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name) { const struct xattr_handler *handler; - if (!*name) - return ERR_PTR(-EINVAL); - for_each_xattr_handler(handlers, handler) { const char *n; -- 2.7.4