linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>, Eryu Guan <eguan@redhat.com>,
	Xiong Zhou <xzhou@redhat.com>
Cc: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 3/3] overlay/013: adjust test expectation to kernel v4.8
Date: Wed, 19 Oct 2016 11:52:33 +0300	[thread overview]
Message-ID: <1476867153-17368-3-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1476867153-17368-1-git-send-email-amir73il@gmail.com>

Commit 4d0c5ba (vfs: do get_write_access() on upper layer of overlayfs)
that was merged for kernel v4.8 changes the behavior of execve+truncate
in a subtle way.

When file is executed from lower and then truncated, the truncation is
allowed, becasue it only affects the size of the copied up file and does
not affect the VM mapping of the executed lower file.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/overlay/013     | 1 -
 tests/overlay/013.out | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/overlay/013 b/tests/overlay/013
index e92eeec..e99e10a 100755
--- a/tests/overlay/013
+++ b/tests/overlay/013
@@ -69,6 +69,5 @@ $SCRATCH_MNT/test_lower
 $SCRATCH_MNT/test_upper
 
 # success, all done
-echo "Silence is golden"
 status=0
 exit
diff --git a/tests/overlay/013.out b/tests/overlay/013.out
index 3e66423..b2c7cc7 100644
--- a/tests/overlay/013.out
+++ b/tests/overlay/013.out
@@ -1,2 +1,2 @@
 QA output created by 013
-Silence is golden
+truncate(test_lower) should have failed
-- 
2.7.4

      parent reply	other threads:[~2016-10-19 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  8:52 [PATCH 1/3] t_truncate_self: describe self better in error message Amir Goldstein
2016-10-19  8:52 ` [PATCH 2/3] overlay/013: fix bug in test_upper creation Amir Goldstein
2016-10-19  8:52 ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476867153-17368-3-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=xzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).