public inbox for linux-unionfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v4 0/6] ovl: concurrent copy up
Date: Tue, 17 Jan 2017 06:34:51 +0200	[thread overview]
Message-ID: <1484627697-17262-1-git-send-email-amir73il@gmail.com> (raw)

Miklos,

Here is v4. Only change from v3 is in patch 1.
Since I only saw your replies for patches 1,2,6,
I assume the the rest are ok?

Patches 1 is the vfs_tmpfile() helper.

Patches 2-4 implement copy up of regular file with the helper.

Patch 5 is the waitqueue patch you sent me.

Patch 6 puts the pieces together for concurrent copy up.

Tested concurrent copy up with this simple test:
$ touch /lower/{empty,4g}
$ truncate -s 4g /lower/4g
$ touch /mnt/4g &  # takes a while
$ touch /mnt/empty # exits immediately
$ touch /mnt/4g    # blocks until %1 completes and can be interrupted

Tested vfs_tmpfile() with generic/004 and generic/389.

Tested with the new overlay/021 which exercises concurrent copy up
using 8 processes on 4 directories and 4K files.

v4:
- Remove redundant dir argument from vfs_tmpfile()

v3:
- Move more code into vfs_tmpfile() helper
- Address Miklos' review comments on patch 6

v2:
- Withdraw the workdir = upperdir hack

v1:
- Initial version

Amir Goldstein (6):
  vfs: create vfs helper vfs_tmpfile()
  ovl: check if upperdir fs supports O_TMPFILE
  ovl: rearrange code in ovl_copy_up_locked()
  ovl: copy up regular file using O_TMPFILE
  ovl: introduce copy up waitqueue
  ovl: concurrent copy up of regular files

 fs/namei.c               | 68 +++++++++++++++++++++++--------------
 fs/overlayfs/copy_up.c   | 88 +++++++++++++++++++++++++++++++++++-------------
 fs/overlayfs/overlayfs.h | 11 ++++++
 fs/overlayfs/ovl_entry.h |  3 ++
 fs/overlayfs/super.c     | 11 ++++++
 fs/overlayfs/util.c      | 30 +++++++++++++++++
 include/linux/fs.h       |  3 ++
 7 files changed, 165 insertions(+), 49 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-01-17  4:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  4:34 Amir Goldstein [this message]
2017-01-17  4:34 ` [PATCH v4 1/6] vfs: create vfs helper vfs_tmpfile() Amir Goldstein
2017-03-06 14:59   ` J. R. Okajima
2017-03-06 15:29     ` Amir Goldstein
2017-01-17  4:34 ` [PATCH v4 2/6] ovl: check if upperdir fs supports O_TMPFILE Amir Goldstein
2017-01-17  4:34 ` [PATCH v4 3/6] ovl: rearrange code in ovl_copy_up_locked() Amir Goldstein
2017-01-17  4:34 ` [PATCH v4 4/6] ovl: copy up regular file using O_TMPFILE Amir Goldstein
2017-01-17  4:34 ` [PATCH v4 5/6] ovl: introduce copy up waitqueue Amir Goldstein
2017-01-17  4:34 ` [PATCH v4 6/6] ovl: concurrent copy up of regular files Amir Goldstein
2017-01-30 16:18 ` [PATCH v4 0/6] ovl: concurrent copy up Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484627697-17262-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox