public inbox for linux-unionfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jan Kara <jack@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
	linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/2] overlayfs: support freeze/thaw/syncfs
Date: Thu, 19 Jan 2017 14:13:26 +0200	[thread overview]
Message-ID: <1484828008-27507-1-git-send-email-amir73il@gmail.com> (raw)

Miklos,

I implemented freeze/thaw of overlayfs, because I need it for
overlay snapshots (CoW decision is made before mnt_wat_write(upper)
and I need to serialize it with snapshot take).

Not sure if there are other use cases for overlayfs freeze??

Tested freeze stress with xfstest generic/068 generic/390.

While staring at the code, I realized that syncfs(2) for overlayfs
seems broken.  It looks like only inodes are synced and upper fs
metadata is not being flushed, but I could be wrong.

Tested sync sanity with -g quick (although no test calls syncfs directly).
Tested the usual unionmount sanity over xfs and over tmpfs.

I am not sure exactly how to write a test case to verify this alleged
breakage?

Jan,

Can you please have a look?

Thanks,

Amir.

Amir Goldstein (2):
  ovl: support freeze/thaw super
  ovl: properly implement sync_filesystem()

 fs/overlayfs/super.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

-- 
2.7.4


             reply	other threads:[~2017-01-19 12:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 12:13 Amir Goldstein [this message]
2017-01-19 12:13 ` [PATCH 1/2] ovl: support freeze/thaw super Amir Goldstein
2017-01-23  8:47   ` Amir Goldstein
2017-01-23 13:23     ` Pavel Emelyanov
2017-04-03 11:27       ` Amir Goldstein
2017-04-04 17:47         ` Serge E. Hallyn
2017-04-04 18:01           ` Tycho Andersen
2017-04-04 18:59             ` Amir Goldstein
2017-04-04 19:07               ` Tycho Andersen
2017-01-19 12:13 ` [PATCH 2/2] ovl: properly implement sync_filesystem() Amir Goldstein
2017-01-24 17:14   ` Christoph Hellwig
2017-01-25 17:51     ` Amir Goldstein
2017-01-19 19:03 ` [PATCH 0/2] overlayfs: support freeze/thaw/syncfs Amir Goldstein
2017-01-20  8:27   ` Jan Kara
2017-01-20  8:41     ` Amir Goldstein
2017-01-20  8:49 ` Amir Goldstein
2017-01-20 12:03   ` Eryu Guan
2017-01-20  8:50 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484828008-27507-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox