[PATCH v4 0/10] fstests: new way to run overlay tests

[Amir Goldstein <amir73il@gmail.com>]

Hi Eryu and all,

This is the 4th revision of new overlayfs config.
The main motivation of this work is to help catch overlayfs bugs
related to leaking objects in underlying (base) fs.

With this change, all you have to do to run overlay tests if you
already have a local.config setup to test a local file system is:
 ./check -overlay

It uses existing local.config that was setup to run tests on
the base fs (e.g. xfs) and you can run './check' and './check -overlay'
without re-formatting the test partitions and without changing the
config file.

The legacy overlayfs configuration, where TEST_DEV is a directory
still works, but it should be deprecated.

I tested ./check -overlay -g quick with both legacy overlay configuration
and the new base fs configuration.

Until now, overlay test configuration was not documented at all.
I updated README per Eryu's request and tried to keep the documentation
short and simple.

Also added README.overlay with some easy example for config files
to use with -overlay.

I would very much appreciate if anyone could test these changes with their
own set of configuration, with or without adding overlay tests into the mix.
You can get the branch for testing from my github tree [1].

Thanks,
Amir.

[1] https://github.com/amir73il/xfstests/tree/ovl_base_fs

v4:
- Address review comments from Eryu
- Fix sanity checks for already mounted scratch base fs
- Fix handling of SCRATCH_DEV_POOL
- Fix problems when run in kvm-xfstests
- Add README.overlay with example config files
- Remove documentation for overlay config sections

v3:
- Mount cycle base test fs
- Fix bugs in non overlay specific sanity checks
- Run -overlay test with existing config file of base fs
- Run overlay tests per base fs by adding overlay config sections

v2:
- Test and scratch base dirs each have thier own base fs
- Support mount cycles of base fs for scratch tests

v1:
- Both test and scratch base dirs on a single base fs


Amir Goldstein (10):
  fstests: sanity check that test partitions are not mounted elsewhere
  fstests: use _test_mount() consistently
  fstests: canonicalize mount points on every config section
  overlay: rename OVERLAY_LOWER/UPPER/WORK_DIR
  overlay: allow SCRATCH_DEV to be the base fs mount point
  overlay: configure TEST/SCRATCH vars to base fs
  overlay: use OVL_BASE_SCRATCH_MNT instead of SCRATCH_DEV
  overlay: fix test and scratch filters for overlay base fs
  overlay: mount/unmount base fs before/after running tests
  generic/064: access SCRATCH_MNT after _scratch_mount

 README            |  16 +++--
 README.overlay    |  46 ++++++++++++
 check             |  18 ++---
 common/config     | 160 ++++++++++++++++++++++++++++++++++++------
 common/filter     |  26 +++++--
 common/rc         | 206 +++++++++++++++++++++++++++++++++++++++---------------
 tests/generic/064 |  10 +--
 tests/overlay/001 |   7 +-
 tests/overlay/002 |   2 +-
 tests/overlay/003 |   5 +-
 tests/overlay/004 |   7 +-
 tests/overlay/005 |  30 ++++----
 tests/overlay/006 |  10 +--
 tests/overlay/008 |   8 +--
 tests/overlay/009 |   2 +-
 tests/overlay/010 |  10 +--
 tests/overlay/011 |   6 +-
 tests/overlay/012 |   4 +-
 tests/overlay/013 |   4 +-
 tests/overlay/014 |  19 ++---
 tests/overlay/015 |   2 +-
 tests/overlay/016 |   2 +-
 tests/overlay/017 |   2 +-
 tests/overlay/018 |   2 +-
 tests/overlay/019 |   2 +-
 tests/overlay/020 |   2 +-
 tests/overlay/021 |   6 +-
 27 files changed, 450 insertions(+), 164 deletions(-)
 create mode 100644 README.overlay

-- 
2.7.4