From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [RFC][PATCH 00/13] overlayfs stable inodes
Date: Mon, 17 Apr 2017 02:59:30 +0300 [thread overview]
Message-ID: <1492387183-18847-1-git-send-email-amir73il@gmail.com> (raw)
Overlayfs inodes are considered unstable in several aspects,
because on a copy up event:
1. st_ino can change
2. st_dev can change
3. hardlinks are broken
4. NFS handle would become stale
5. content of read-only file descriptor would become stale
This patch set 'stabilizes' overlayfs inodes w.r.t. st_ino/st_dev
and takes some big steps in the direction of stabilizing hardlinks
and NFS handles.
The full work is available at [1] and includes also an untested
WIP for NFS export support.
This work relies heavily on inode and dentry cache - so long as
the overlayfs dcache is fully populated, hardlinks should never be
broken and NFS handles should never become stale on copy up.
The missing piece of the puzzle is a persistent mapping from
lower entries to upper entries, so that overlay entries could be
reconstructed from their stable (lower) unique identifier.
But the work has merit even without the missing piece, because it
stabilizes st_ino/st_dev and prevents breaking hardlinks in many
use cases.
[1] https://github.com/amir73il/linux/commits/ovl-nfs-export
Amir Goldstein (13):
ovl: check if all layers are on the same fs
ovl: redirect dir by file handle on copy up
ovl: lookup redirect by file handle
ovl: store file handle of stable inode
ovl: lookup stable inode by file handle
ovl: move inode helpers to inode.c
ovl: create helpers for initializing hashed inode
ovl: allow hashing non upper inodes
ovl: inherit overlay inode ino/generation from real inode
ovl: hash overlay inodes by stable inode
ovl: fix du --one-file-system on overlay mount
ovl: constant ino across copy up
ovl: try to hardlink upper on copy up of lower hardlinks
fs/overlayfs/Kconfig | 16 ++++
fs/overlayfs/copy_up.c | 130 ++++++++++++++++++++++++++-
fs/overlayfs/dir.c | 2 +-
fs/overlayfs/inode.c | 106 ++++++++++++++++++++--
fs/overlayfs/namei.c | 226 ++++++++++++++++++++++++++++++++++++++++++-----
fs/overlayfs/overlayfs.h | 40 +++++++--
fs/overlayfs/ovl_entry.h | 4 +-
fs/overlayfs/readdir.c | 85 ++++++++++++++++--
fs/overlayfs/super.c | 37 +++++++-
fs/overlayfs/util.c | 51 +++++++----
10 files changed, 633 insertions(+), 64 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-16 23:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 23:59 Amir Goldstein [this message]
2017-04-16 23:59 ` [RFC][PATCH 01/13] ovl: check if all layers are on the same fs Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 02/13] ovl: redirect dir by file handle on copy up Amir Goldstein
2017-04-17 13:33 ` Rock Lee
2017-04-17 14:03 ` Amir Goldstein
2017-04-17 19:49 ` Vivek Goyal
2017-04-17 21:14 ` Amir Goldstein
2017-04-19 15:16 ` Miklos Szeredi
2017-04-19 15:27 ` Amir Goldstein
2017-04-19 15:33 ` Miklos Szeredi
2017-04-19 15:43 ` Amir Goldstein
2017-04-20 8:55 ` Amir Goldstein
2017-04-21 15:02 ` Miklos Szeredi
2017-04-21 15:29 ` Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 03/13] ovl: lookup redirect by file handle Amir Goldstein
2017-04-18 13:05 ` Vivek Goyal
2017-04-18 14:05 ` Amir Goldstein
2017-04-18 18:32 ` Vivek Goyal
2017-04-18 18:57 ` Amir Goldstein
2017-04-19 15:21 ` Miklos Szeredi
2017-04-19 15:35 ` Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 04/13] ovl: store file handle of stable inode Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 05/13] ovl: lookup stable inode by file handle Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 06/13] ovl: move inode helpers to inode.c Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 07/13] ovl: create helpers for initializing hashed inode Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 08/13] ovl: allow hashing non upper inodes Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 09/13] ovl: inherit overlay inode ino/generation from real inode Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 10/13] ovl: hash overlay inodes by stable inode Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 11/13] ovl: fix du --one-file-system on overlay mount Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 12/13] ovl: constant ino across copy up Amir Goldstein
2017-04-16 23:59 ` [RFC][PATCH 13/13] ovl: try to hardlink upper on copy up of lower hardlinks Amir Goldstein
2017-04-18 18:37 ` [RFC][PATCH 00/13] overlayfs stable inodes Amir Goldstein
2017-04-19 9:16 ` Miklos Szeredi
2017-04-19 10:37 ` Amir Goldstein
2017-04-19 13:52 ` Miklos Szeredi
2017-04-19 14:46 ` Amir Goldstein
2017-04-19 15:01 ` Miklos Szeredi
2017-04-19 15:17 ` Amir Goldstein
2017-04-19 22:58 ` Darrick J. Wong
2017-04-19 23:15 ` Andreas Dilger
2017-04-20 5:43 ` Amir Goldstein
2017-04-20 8:45 ` Miklos Szeredi
2017-04-20 8:47 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492387183-18847-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox