From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-unionfs@vger.kernel.org
Subject: [PATCH 1/3] ovl: fix wrong error handling of ovl_set_impure()
Date: Wed, 17 May 2017 00:12:39 +0300 [thread overview]
Message-ID: <1494969161-30267-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1494969161-30267-1-git-send-email-amir73il@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
fs/overlayfs/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index 5ad6ccf..9b221cf 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -973,13 +973,13 @@ static int ovl_rename(struct inode *olddir, struct dentry *old,
if (ovl_type_origin(old) && !ovl_type_merge(new->d_parent)) {
err = ovl_set_impure(new->d_parent, new_upperdir);
if (err)
- goto out_dput;
+ goto out_revert_creds;
}
if (!overwrite && ovl_type_origin(new) &&
!ovl_type_merge(old->d_parent)) {
err = ovl_set_impure(old->d_parent, old_upperdir);
if (err)
- goto out_dput;
+ goto out_revert_creds;
}
}
--
2.7.4
next prev parent reply other threads:[~2017-05-16 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 21:12 [PATCH 0/3] ovl: corner cases of upper with no xattr support Amir Goldstein
2017-05-16 21:12 ` Amir Goldstein [this message]
2017-05-16 21:12 ` [PATCH 2/3] ovl: check on mount time if upper fs supports setting xattr Amir Goldstein
2017-05-16 21:12 ` [PATCH 3/3] ovl: handle rename when upper doesn't supports xattr Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494969161-30267-2-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox