Re: [PATCH v3 5/5] ovl: consistent st_ino/d_ino

Amir Goldstein
2017-08-16T11:16:07Z

On Mon, Jul 31, 2017 at 12:58 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Sat, Jul 29, 2017 at 12:33 PM, Amir Goldstein <amir73il@gmail.com> wrote:

>
>> One thing that stands out in "my" patch ("ovl: constant d_ino across copy up")
>> The comments and commit message claim "When all layers are on the same fs",
>> but the patch doesn't actually checks that.
>
> I does in ovl_cache_update_ino(). That check would be more logical
> in ovl_calc_d_ino(), though. Fixed.
>

I see the patches in overlayfs-next still don't have the ovl_same_sb()
test in ovl_calc_d_ino(). I don't really mind.
BTW, do you intend to apply/rework Chandan's non-samefs patches for next?
if so, the current location of ovl_same_sb() really doesn't matter..

Amir.