Re: [PATCH v3 5/5] ovl: consistent st_ino/d_ino

Amir Goldstein
2017-06-21T09:36:59Z

On Wed, Jun 21, 2017 at 12:20 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Wed, Jun 21, 2017 at 11:05 AM, Amir Goldstein <amir73il@gmail.com> wrote:

>>
>> Following up on your idea:
>> - check in ovl_iterate() if version has changed and if dir became impure
>> - if it did, populate od->cache, but keep the dir od->is_real
>> - iterate upper cache entries and call ovl_cache_update_ino()
>> - Then actor of real dir iterator can use the cache to ommit entries or use
>> p->ino from cache if p->real_ino match real d_ino, but differs from p->ino.
>
> For non-merge dirs we can have a simplified cache just containing the
> entries with origin, recreated when the version changes or updated in
> rename, whichever is simpler. A non-merge dir will never become a
> merge one, so we can keep the handling separate.
>

And use this cache to ommit/fix entries with actor?

Just thought of another issue related to pseudo lower st_dev
we need the underlying iter actor also for replacing real st_dev
with pseudo st_dev.

Also, just realized that with inodes index, the upper non-dir inodes
with nlink == 1 are not origin suspects. Can that help us somehow?